From: rir <rirans@comcast.net>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: rir <rirans@comcast.net>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: small patch
Date: Sun, 10 Oct 2021 16:15:01 -0400
Message-ID: <20211010201501.7e35hmwmdxqynjko@localhost> (raw)
In-Reply-To: <57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at>
References: <20211001163938.ifg4ayrsjwd7r6zr@localhost>
<1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at>
<20211007033905.pmsg5qnyqceepfva@localhost>
<9f703511c57d6bb0f44f9a968414869854ae50ea.camel@cybertec.at>
<20211007200612.rkxxgeorw6w4fpjp@localhost>
<57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at>
On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote:
> On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
> So I suggest that you change the syntax diagram to
>
> FETCH [ direction ] [ FROM | IN ] cursor_name
> Then I agree that the "empty or" can be removed.
> I remain of the opinion that the comments should be
> retained, but we can leave that for somebody else to
> decide.
I accept your three points above.
The MOVE synopsis shows the same parsing as I presented,
should it be changed in the same way (move a square bracket left to
be after <direction>)? My guess is yes, but I've never used an
SQL cursor.
When this convo settles, I send a new patch. Probably
here in the group. If I have a few more, or a complex one,
I'll check out the other submission method.
Rob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: rirans@comcast.net, laurenz.albe@cybertec.at, pgsql-docs@lists.postgresql.org
Subject: Re: small patch
In-Reply-To: <20211010201501.7e35hmwmdxqynjko@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox