pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: rir <rirans@comcast.net>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: small patch
Date: Fri, 08 Oct 2021 14:47:43 +0200
Message-ID: <57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at> (raw)
In-Reply-To: <20211007200612.rkxxgeorw6w4fpjp@localhost>
References: <20211001163938.ifg4ayrsjwd7r6zr@localhost>
	<1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at>
	<20211007033905.pmsg5qnyqceepfva@localhost>
	<9f703511c57d6bb0f44f9a968414869854ae50ea.camel@cybertec.at>
	<20211007200612.rkxxgeorw6w4fpjp@localhost>

On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
> > > > - we should retain "empty or one of", otherwise the following syntax
> > > >   would be undocumented:
> 
> For myself,
>    'FETCH [ <direction> [ FROM | IN ] ] <cursor_name>'
> clearly indicates that 'direction' is optional.

Yes, but since [ FROM | IN ] is inside the bracket, that
diagram would not account for "direction" being omitted
while retaining FROM.

So I suggest that you change the syntax diagram to

FETCH [ direction ] [ FROM | IN ] cursor_name

Then I agree that the "empty or" can be removed.
I think that would be a good idea, and it would add
clarity.

I remain of the opinion that the comments should be
retained, but we can leave that for somebody else to
decide.

Do you want to prepare a new patch and register it in
the commitfest?

Yours,
Laurenz Albe






view thread (16+ messages)  latest in thread

Message-ID: <57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at>
Permalink:  ../57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at/
Also on:    postgresql.org/message-id/57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: laurenz.albe@cybertec.at, rirans@comcast.net, pgsql-docs@lists.postgresql.org
  Subject: Re: small patch
  In-Reply-To: <57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox