agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: elionescu@yahoo.com <elionescu@yahoo.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: incorrect (incomplete) description for "alter domain"
Date: Mon, 29 Jul 2024 11:17:41 -0400
Message-ID: <2596729.1722266261@sss.pgh.pa.us> (raw)
In-Reply-To: <2585954.1722265086@sss.pgh.pa.us>
References: <172225092461.915373.6103973717483380183@wrigleys.postgresql.org>
<CAKFQuwbZ3KDq3CtG0qtw7gVT4EWgmD8XFMktEFcruVs98ihCSw@mail.gmail.com>
<2585954.1722265086@sss.pgh.pa.us>
I wrote:
> I think the page is technically correct, but I'm inclined to duplicate
> this text from the CREATE DOMAIN page:
> where domain_constraint is:
> [ CONSTRAINT constraint_name ]
> { NOT NULL | NULL | CHECK (expression) }
> rather than making readers go look that up.
Actually, there *is* a bug in the description, because experimentation
shows that CREATE DOMAIN accepts NULL in this syntax (as advertised)
but ALTER DOMAIN does not. We could alternatively decide that that's
a code bug and make ALTER DOMAIN take it, but I don't think it's worth
any effort (and this behavior may actually have been intentional, too).
I think we should just add
where domain_constraint is:
[ CONSTRAINT constraint_name ]
{ NOT NULL | CHECK (expression) }
to the ALTER DOMAIN page, and then remove the claim that it's
identical to CREATE DOMAIN.
regards, tom lane
view thread (9+ messages) latest in thread
Message-ID: <2596729.1722266261@sss.pgh.pa.us>
Permalink: ../2596729.1722266261@sss.pgh.pa.us/
Also on: postgresql.org/message-id/2596729.1722266261@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, elionescu@yahoo.com, pgsql-docs@lists.postgresql.org
Subject: Re: incorrect (incomplete) description for "alter domain"
In-Reply-To: <2596729.1722266261@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox