pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedTypo in description of replay_lag attribute in pg_stat_replication view
7+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2018-12-05 99f9ccee51 367f362b2d db35e959bb Fix invalid value of synchronous_commit in description of flush_lag
* Typo in description of replay_lag attribute in pg_stat_replication view
@ 2018-12-03 15:18 Maksim Milyutin <milyutinma@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Maksim Milyutin @ 2018-12-03 15:18 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hello!
I have noticed that in description of *flush_lag* in pg_stat_replication
view
(https://www.postgresql.org/docs/current/monitoring-stats.html#PG-STAT-REPLICATION-VIEW)
there exists unknown value of synchronous_commit parameter -
*remote_flush*. I think it was meant to use the value *on*.
Small patch is attached.
--
Regards, Maksim Milyutin
Attachments:
flush_lag_fix.patch (text/x-patch, 695B) download
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 4164d84..33869be 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -1856,7 +1856,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
notification that this standby server has written and flushed it
(but not yet applied it). This can be used to gauge the delay that
<literal>synchronous_commit</literal> level
- <literal>remote_flush</literal> incurred while committing if this
+ <literal>on</literal> incurred while committing if this
server was configured as a synchronous standby.</entry>
</row>
<row>
* Re: Typo in description of replay_lag attribute in pg_stat_replication view
@ 2018-12-04 00:18 Michael Paquier <michael@paquier.xyz>
parent: Maksim Milyutin <milyutinma@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2018-12-04 00:18 UTC (permalink / raw)
To: Maksim Milyutin <milyutinma@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org
On Mon, Dec 03, 2018 at 06:18:30PM +0300, Maksim Milyutin wrote:
> I have noticed that in description of *flush_lag* in pg_stat_replication
> view (https://www.postgresql.org/docs/current/monitoring-stats.html#PG-STAT-REPLICATION-VIEW)
> there exists unknown value of synchronous_commit parameter - *remote_flush*.
> I think it was meant to use the value *on*.
Yes, you are right. It should be "on" as "remote_flush" is not a valid
value. remote_flush is listed in SyncCommitLevel though, so this makes
me wonder if we should also introduce a new value for this purpose
available for users. The fix you propose looks good to me. Any
opinions from others?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Typo in description of replay_lag attribute in pg_stat_replication view
@ 2018-12-04 00:28 Thomas Munro <thomas.munro@enterprisedb.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Munro @ 2018-12-04 00:28 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: milyutinma@gmail.com; pgsql-docs@lists.postgresql.org
On Tue, Dec 4, 2018 at 1:18 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Mon, Dec 03, 2018 at 06:18:30PM +0300, Maksim Milyutin wrote:
> > I have noticed that in description of *flush_lag* in pg_stat_replication
> > view (https://www.postgresql.org/docs/current/monitoring-stats.html#PG-STAT-REPLICATION-VIEW)
> > there exists unknown value of synchronous_commit parameter - *remote_flush*.
> > I think it was meant to use the value *on*.
>
> Yes, you are right. It should be "on" as "remote_flush" is not a valid
> value. remote_flush is listed in SyncCommitLevel though, so this makes
> me wonder if we should also introduce a new value for this purpose
> available for users. The fix you propose looks good to me. Any
> opinions from others?
+1 for the patch.
As for introducing remote_flush as the true name of the level, this
was discussed but somehow went off-course and never made it to the
finish line:
https://www.postgresql.org/message-id/flat/CAEepm%3D3FFaanSS4sugG%2BApzq2tCVjEYCO2wOQBod2d7GWb%3DDvA...
--
Thomas Munro
http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Typo in description of replay_lag attribute in pg_stat_replication view
@ 2018-12-04 02:19 Michael Paquier <michael@paquier.xyz>
parent: Thomas Munro <thomas.munro@enterprisedb.com>
0 siblings, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2018-12-04 02:19 UTC (permalink / raw)
To: Thomas Munro <thomas.munro@enterprisedb.com>; +Cc: milyutinma@gmail.com; pgsql-docs@lists.postgresql.org
On Tue, Dec 04, 2018 at 01:28:15PM +1300, Thomas Munro wrote:
> On Tue, Dec 4, 2018 at 1:18 PM Michael Paquier <michael@paquier.xyz> wrote:
>> Yes, you are right. It should be "on" as "remote_flush" is not a valid
>> value. remote_flush is listed in SyncCommitLevel though, so this makes
>> me wonder if we should also introduce a new value for this purpose
>> available for users. The fix you propose looks good to me. Any
>> opinions from others?
>
> +1 for the patch.
Thanks for confirming, Thomas. I'll go apply hopefully tomorrow if
nobody has objections.
> As for introducing remote_flush as the true name of the level, this
> was discussed but somehow went off-course and never made it to the
> finish line:
>
> https://www.postgresql.org/message-id/flat/CAEepm%3D3FFaanSS4sugG%2BApzq2tCVjEYCO2wOQBod2d7GWb%3DDvA...
Oh, I forgot this one. We may want to revive that... remote_flush is
more meaningful than on, especially since there are more and more
possible values for synchronous_commit.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Typo in description of replay_lag attribute in pg_stat_replication view
@ 2018-12-04 22:24 Maksim Milyutin <milyutinma@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 7+ messages in thread
From: Maksim Milyutin @ 2018-12-04 22:24 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; Thomas Munro <thomas.munro@enterprisedb.com>; +Cc: pgsql-docs@lists.postgresql.org
04.12.2018 5:19, Michael Paquier wrote:
> On Tue, Dec 04, 2018 at 01:28:15PM +1300, Thomas Munro wrote:
>> On Tue, Dec 4, 2018 at 1:18 PM Michael Paquier <michael@paquier.xyz> wrote:
>>> Yes, you are right. It should be "on" as "remote_flush" is not a valid
>>> value. remote_flush is listed in SyncCommitLevel though, so this makes
>>> me wonder if we should also introduce a new value for this purpose
>>> available for users. The fix you propose looks good to me. Any
>>> opinions from others?
>> +1 for the patch.
> Thanks for confirming, Thomas. I'll go apply hopefully tomorrow if
> nobody has objections.
>
>> As for introducing remote_flush as the true name of the level, this
>> was discussed but somehow went off-course and never made it to the
>> finish line:
>>
>> https://www.postgresql.org/message-id/flat/CAEepm%3D3FFaanSS4sugG%2BApzq2tCVjEYCO2wOQBod2d7GWb%3DDvA...
> Oh, I forgot this one. We may want to revive that... remote_flush is
> more meaningful than on, especially since there are more and more
> possible values for synchronous_commit.
Yeah, I think the notion *remote_flush level* is more appropriate
especially in the context of sync replication. Within this context maybe
it makes sense to replace the word *level* to *value* in description of
*flush_lag*?
--
Regards,
Maksim Milyutin
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Typo in description of replay_lag attribute in pg_stat_replication view
@ 2018-12-05 01:04 Michael Paquier <michael@paquier.xyz>
parent: Maksim Milyutin <milyutinma@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2018-12-05 01:04 UTC (permalink / raw)
To: Maksim Milyutin <milyutinma@gmail.com>; +Cc: Thomas Munro <thomas.munro@enterprisedb.com>; pgsql-docs@lists.postgresql.org
On Wed, Dec 05, 2018 at 01:24:22AM +0300, Maksim Milyutin wrote:
> Yeah, I think the notion *remote_flush level* is more appropriate especially
> in the context of sync replication. Within this context maybe it makes sense
> to replace the word *level* to *value* in description of *flush_lag*?
I am not sure that this is an improvement. Anyway, I have committed
your original patch as that's clearly a mistake and back-patched down to
v10.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Typo in description of replay_lag attribute in pg_stat_replication view
@ 2018-12-05 07:52 Maksim Milyutin <milyutinma@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 7+ messages in thread
From: Maksim Milyutin @ 2018-12-05 07:52 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Thomas Munro <thomas.munro@enterprisedb.com>; pgsql-docs@lists.postgresql.org
05.12.2018 4:04, Michael Paquier wrote:
> On Wed, Dec 05, 2018 at 01:24:22AM +0300, Maksim Milyutin wrote:
>> Yeah, I think the notion *remote_flush level* is more appropriate especially
>> in the context of sync replication. Within this context maybe it makes sense
>> to replace the word *level* to *value* in description of *flush_lag*?
> I am not sure that this is an improvement. Anyway, I have committed
> your original patch as that's clearly a mistake and back-patched down to
> v10.
Ok, thanks.
--
Regards,
Maksim Milyutin
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2018-12-05 07:52 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03 15:18 Typo in description of replay_lag attribute in pg_stat_replication view Maksim Milyutin <milyutinma@gmail.com>
2018-12-04 00:18 ` Michael Paquier <michael@paquier.xyz>
2018-12-04 00:28 ` Thomas Munro <thomas.munro@enterprisedb.com>
2018-12-04 02:19 ` Michael Paquier <michael@paquier.xyz>
2018-12-04 22:24 ` Maksim Milyutin <milyutinma@gmail.com>
2018-12-05 01:04 ` Michael Paquier <michael@paquier.xyz>
2018-12-05 07:52 ` Maksim Milyutin <milyutinma@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox