pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
CVS in docs
20+ messages / 5 participants
[nested] [flat]

* CVS in docs
@ 2010-09-21 22:11  Thom Brown <thom@linux.com>
  0 siblings, 1 reply; 20+ messages in thread

From: Thom Brown @ 2010-09-21 22:11 UTC (permalink / raw)
  To: pgsql-docs

Do references to the CVS need removing now that everything is on GIT?

Is the CVS page still relevant?
http://www.postgresql.org/docs/9.0/static/anoncvs.html (cvs.sgml)
This refers to that page and the anoncvs web interface:
http://www.postgresql.org/docs/9.0/static/release.html (release.sgml)
The installation page talks about building from a CVS tree:
http://www.postgresql.org/docs/9.0/static/install-requirements.html
(installation.sgml)
HOT (Heap-Only Typles) in acronyms (acronyms.sgml) links to anoncvs,
so maybe point it to
http://git.postgresql.org/gitweb?p=postgresql.git;a=blob_plain;f=src/backend/access/heap/README.HOT;...
NLS info for translators refers to CVS:
http://www.postgresql.org/docs/9.0/static/nls-translator.html
(nls.sgml)
Bug reporting mentions CVS:
http://www.postgresql.org/docs/9.0/static/bug-reporting.html
(problems.sgml)

-- 
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-21 22:38  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Thom Brown <thom@linux.com>
  0 siblings, 1 reply; 20+ messages in thread

From: Tom Lane @ 2010-09-21 22:38 UTC (permalink / raw)
  To: Thom Brown <thom@linux.com>; +Cc: pgsql-docs

Thom Brown <thom@linux.com> writes:
> Do references to the CVS need removing now that everything is on GIT?

The chapter about CVS obviously needs to be replaced.  I was talking
to Magnus about that earlier, and we both felt that that needs to be
back-patched, if only so that there are non-obsolete repository URLs
in the next back-branch updates.  I'm not sure that we need the
tutorial-ish description of how to do checkouts etc, but at the least
we need the URLs.

A quick grep suggests that there are a dozen or two other passing
references to CVS in docs and comments, which'd be worth cleaning
up in HEAD, but probably not worth back-patching.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 12:05  Magnus Hagander <magnus@hagander.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 2 replies; 20+ messages in thread

From: Magnus Hagander @ 2010-09-22 12:05 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

On Wed, Sep 22, 2010 at 00:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thom Brown <thom@linux.com> writes:
>> Do references to the CVS need removing now that everything is on GIT?
>
> The chapter about CVS obviously needs to be replaced.  I was talking
> to Magnus about that earlier, and we both felt that that needs to be
> back-patched, if only so that there are non-obsolete repository URLs
> in the next back-branch updates.  I'm not sure that we need the
> tutorial-ish description of how to do checkouts etc, but at the least
> we need the URLs.

Here's a suggested patch for this. Most of it is just taking out the
cvs documentation since most of the git info was in there already. I
also moved some notes around.

Finally, I took the liberty to rip out the <appendixinfo> part listing
specific authors. Most of what they did is gone now anyway, and we
don't have those entries on other files.


> A quick grep suggests that there are a dozen or two other passing
> references to CVS in docs and comments, which'd be worth cleaning
> up in HEAD, but probably not worth back-patching.

Agreed.

What about the messages in configure?
"configure:*** Without Bison you will not be able to build PostgreSQL
from CVS nor"

coming out of config/*.m4?


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachments:

git_docs.patch (text/x-patch, 14.1K) download diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile index 622aa4f..a7f0c8d 100644 --- a/doc/src/sgml/Makefile +++ b/doc/src/sgml/Makefile @@ -8,7 +8,7 @@ # This makefile is for building and installing the documentation. # When a release tarball is created, the documentation files are -# prepared using the distprep target. In CVS-based trees these files +# prepared using the distprep target. In Git-based trees these files # don't exist, unless explicitly built, so we skip the installation in # that case. diff --git a/doc/src/sgml/filelist.sgml b/doc/src/sgml/filelist.sgml index ef86190..5d62a53 100644 --- a/doc/src/sgml/filelist.sgml +++ b/doc/src/sgml/filelist.sgml @@ -137,7 +137,7 @@ <!-- appendixes --> <!entity contacts SYSTEM "contacts.sgml"> -<!entity cvs SYSTEM "cvs.sgml"> +<!entity sourcerepo SYSTEM "sourcerepo.sgml"> <!entity datetime SYSTEM "datetime.sgml"> <!entity docguide SYSTEM "docguide.sgml"> <!entity errcodes SYSTEM "errcodes.sgml"> diff --git a/doc/src/sgml/install-win32.sgml b/doc/src/sgml/install-win32.sgml index a1fea05..50c28eb 100644 --- a/doc/src/sgml/install-win32.sgml +++ b/doc/src/sgml/install-win32.sgml @@ -176,7 +176,7 @@ $ENV{PATH}=$ENV{PATH} . ';c:\some\where\bison\bin'; <term><productname>Bison</productname> and <productname>Flex</productname></term> <listitem><para> - Bison and Flex are required to build from CVS, but not required when + Bison and Flex are required to build from Git, but not required when building from a release file. Note that only Bison 1.875 or versions 2.2 and later will work. Also, Flex version 2.5.31 or later is required. Bison can be downloaded from <ulink url="http://gnuwin32.sourceforge.net"></>. diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml index e09ff18..f3659ba 100644 --- a/doc/src/sgml/installation.sgml +++ b/doc/src/sgml/installation.sgml @@ -274,7 +274,7 @@ su - postgres </para> <para> - If you are building from a <acronym>CVS</acronym> tree instead of + If you are building from a <productname>Git</productname> tree instead of using a released source package, or if you want to do server development, you also need the following packages: @@ -295,7 +295,7 @@ su - postgres </indexterm> GNU <application>Flex</> and <application>Bison</> - are needed to build from a CVS checkout, or if you changed the actual + are needed to build from a Git checkout, or if you changed the actual scanner and parser definition files. If you need them, be sure to get <application>Flex</> 2.5.31 or later and <application>Bison</> 1.875 or later. Other <application>lex</> @@ -308,7 +308,7 @@ su - postgres <primary>perl</primary> </indexterm> - <application>Perl</> 5.8 or later is needed to build from a CVS checkout, + <application>Perl</> 5.8 or later is needed to build from a Git checkout, or if you changed the input files for any of the build steps that use Perl scripts. If building on Windows you will need <application>Perl</> in any case. @@ -361,7 +361,7 @@ su - postgres <para> You can also get the source directly from the version control repository, see - <xref linkend="cvs">. + <xref linkend="sourcerepo">. </para> </sect1> ]]> @@ -2562,7 +2562,7 @@ make MAX_CONNECTIONS=5 check <para> Aside from the PostgreSQL source distribution, you will need GNU make (HP's make will not do), and either GCC or HP's full ANSI C - compiler. If you intend to build from CVS sources rather than a + compiler. If you intend to build from Git sources rather than a distribution tarball, you will also need Flex (GNU lex) and Bison (GNU yacc). We also recommend making sure you are fairly up-to-date on HP patches. At a minimum, if you are building 64 diff --git a/doc/src/sgml/postgres.sgml b/doc/src/sgml/postgres.sgml index 79cd44f..4d32f7d 100644 --- a/doc/src/sgml/postgres.sgml +++ b/doc/src/sgml/postgres.sgml @@ -258,7 +258,7 @@ &release; &contrib; &external-projects; - &cvs; + &sourcerepo; &docguide; &acronyms; diff --git a/doc/src/sgml/problems.sgml b/doc/src/sgml/problems.sgml index 0649431..5704d3f 100644 --- a/doc/src/sgml/problems.sgml +++ b/doc/src/sgml/problems.sgml @@ -228,8 +228,8 @@ If the function or the options do not exist then your version is more than old enough to warrant an upgrade. If you run a prepackaged version, such as RPMs, say so, including any - subversion the package might have. If you are talking about a CVS - snapshot, mention that, including its date and time. + subversion the package might have. If you are talking about a Git + snapshot, mention that, including the commit hash. </para> <para> diff --git a/doc/src/sgml/release.sgml b/doc/src/sgml/release.sgml index 1a1ad3d..3b7170b 100644 --- a/doc/src/sgml/release.sgml +++ b/doc/src/sgml/release.sgml @@ -49,11 +49,11 @@ can be created without links to the main documentation. Don't use <xref>. <para> A complete list of changes for each release can be obtained by - viewing the <link linkend="cvs">CVS</link> logs for each release. + viewing the <link linkend="git">Git</link> logs for each release. The <ulink url="http://archives.postgresql.org/pgsql-committers/"><literal>pgsql-committers</literal> email list</ulink> records all source code changes as well. There is also - a <ulink url="http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/">web + a <ulink url="http://git.postgresql.org/gitweb?p=postgresql.git;a=summary">web interface</ulink> that shows changes to specific files. <!-- we need a file containing the CVS logs for each release, and something like the SVN web interface that groups commits but has branches --> diff --git a/doc/src/sgml/sourcerepo.sgml b/doc/src/sgml/sourcerepo.sgml index 55de20c..9c815a8 100644 --- a/doc/src/sgml/sourcerepo.sgml +++ b/doc/src/sgml/sourcerepo.sgml @@ -1,53 +1,29 @@ -<!-- doc/src/sgml/cvs.sgml --> - -<appendix id="cvs"> - <appendixinfo> - <authorgroup> - <author> - <firstname>Marc</firstname> - <surname>Fournier</surname> - </author> - <author> - <firstname>Tom</firstname> - <surname>Lane</surname> - </author> - <author> - <firstname>Thomas</firstname> - <surname>Lockhart</surname> - </author> - <author> - <firstname>David</firstname> - <surname>Fetter</surname> - </author> - </authorgroup> - <date>1999-05-20</date> - </appendixinfo> +<!-- doc/src/sgml/sourcerepo.sgml --> +<appendix id="sourcerepo"> <title>The Source Code Repository</title> <para> The <productname>PostgreSQL</productname> source code is stored and managed using the - <productname>CVS</productname> version control system. An official mirror using - <productname>Git</productname> is also available, for those who wish to use a - distributed version control system. This mirror is automatically - updated whenever the main repository changes, so it always contains the latest - versions of all branches. - </para> - - <para> - Using <productname>Git</> is the most flexible way to work with the source, and it - allows you to work offline without having constant access to the project servers. - <productname>rsync</> based <productname>CVS</> also lets you work offline, but - lacks many of the other advantages of <productname>Git</>. + <productname>Git</productname> version control system. An public mirror of this + is available and updated within a minute of the master repository. </para> <para> Our wiki, <ulink - url="http://wiki.postgresql.org/wiki/Working_with_CVS"></ulink> and - <ulink url="http://wiki.postgresql.org/wiki/Working_with_Git"></ulink>, - has additional details on working with CVS and Git. + url="http://wiki.postgresql.org/wiki/Working_with_Git"></ulink>, + has additional details on working with Git. </para> + <para> + Note that building <productname>PostgreSQL</productname> from the source + repository requires reasonably up-to-date versions of <application>bison</> + and <application>flex</>. These tools are not needed to build from a + distribution tarball since their output is included in the file. + You will need Perl as well, but otherwise the tool requirements are the + same. + </para> + <sect1 id="git"> <title>Getting The Source Via <productname>Git</></title> @@ -92,7 +68,7 @@ git clone http://git.postgresql.org/git/postgresql.git </programlisting> The HTTP protocol is less efficient than the Git protocol, so it will be - slightly slower to use. + slower to use. </para> </step> @@ -114,158 +90,4 @@ git fetch </para> </sect1> - <sect1 id="anoncvs"> - <title>Getting The Source Via Anonymous <productname>CVS</productname></title> - - <para> - If you would like to keep up with the current sources on a regular - basis, you can fetch them from our <productname>CVS</productname> server - and then use <productname>CVS</productname> to - retrieve updates from time to time. - </para> - - <procedure> - <title>Anonymous CVS</title> - - <step> - <para> - You will need a local copy of <productname>CVS</productname> - (Concurrent Version Control System), which you can get from - <ulink url="http://www.nongnu.org/cvs/"></ulink> (the official - site with the latest version) or any GNU software archive site - (often somewhat outdated). Many systems have a recent version of - <application>cvs</application> installed by default. - </para> - </step> - - <step> - <para> - Do an initial login to the <productname>CVS</productname> server: - -<programlisting> -cvs -d :pserver:anoncvs@anoncvs.postgresql.org:/projects/cvsroot login -</programlisting> - - You will be prompted for a password; you can enter anything except - an empty string. - </para> - - <para> - You should only need to do this once, since the password will be - saved in <filename>.cvspass</filename> in your home directory. - </para> - </step> - - <step> - <para> - Fetch the <productname>PostgreSQL</productname> sources: -<programlisting> -cvs -z3 -d :pserver:anoncvs@anoncvs.postgresql.org:/projects/cvsroot co -P pgsql -</programlisting> - - This installs the <productname>PostgreSQL</productname> sources into a - subdirectory <filename>pgsql</filename> - of the directory you are currently in. - </para> - - <para> - This initial checkout is a little slower than simply downloading - a <filename>tar.gz</filename> file. The advantage of <productname>CVS</> - doesn't show up until you want to update the file set later on. - </para> - </step> - - <step> - <para> - Whenever you want to update to the latest <productname>CVS</productname> sources, - <command>cd</command> into - the <filename>pgsql</filename> subdirectory, and issue: -<programlisting> -cvs -z3 update -d -P -</programlisting> - - This will fetch only the changes since the last time you updated. - You can update in just a couple of minutes, typically, even over - a modem-speed line. - </para> - </step> - - <step> - <para> - You can save yourself some typing by making a file <filename>.cvsrc</filename> - in your home directory that contains: - -<programlisting> -cvs -z3 -update -d -P -</programlisting> - - This supplies the <option>-z3</option> option to all <command>cvs</> commands, and the - <option>-d</option> and <option>-P</option> options to <command>cvs update</>. Then you just have - to say: -<programlisting> -cvs update -</programlisting> - - to update your files. - </para> - </step> - </procedure> - - <para> - <productname>CVS</productname> can do a lot of other things, such - as fetching prior revisions of the - <productname>PostgreSQL</productname> sources rather than the - latest development version. For more info consult the manual that - comes with <productname>CVS</productname>, or see the online - documentation at <ulink url="http://www.nongnu.org/cvs/"></ulink>. - </para> - <para> - <productname>CVS</productname> has deficiencies. For example, - generating diffs that add or remove files requires write access to the - CVS repository. To work around that deficiency, use - <productname>cvsutils</productname>, which is packaged in several - operating systems, and is available in source form at <ulink - url="http://www.red-bean.com/cvsutils/"></ulink>, or use <productname>Git</> - or another system designed to work offline. - </para> - - <para> - Note that building <productname>PostgreSQL</productname> from a CVS - pull requires reasonably up-to-date versions of <application>bison</> - and <application>flex</>, which are not needed to build from a distribution - tarball because the files made with them are pre-built in a tarball. - You will need Perl as well. - Otherwise the tool requirements are the same as building from source. - </para> - </sect1> - - <sect1 id="rsync"> - <title>Getting The Source Via <productname>rsync</productname></title> - - <para> - An alternative to using anonymous CVS for retrieving the - <productname>PostgreSQL</productname> source tree is - <productname>rsync</productname>, an incremental file transfer tool. - A major advantage to using <productname>rsync</productname> instead of - plain <productname>cvs</> is that it - can reliably replicate the <emphasis>entire</emphasis> CVS repository - on your local system, allowing fast local access to <command>cvs</> - operations such as <option>log</option> and <option>diff</option>. - Other advantages include fast synchronization to the - <productname>PostgreSQL</productname> server due to an efficient - streaming transfer protocol which only sends the changes since the last - update. - </para> - - <para> - You can download the CVS repository using this command: -<programlisting> -rsync -avzH --delete anoncvs.postgresql.org::pgsql-cvs cvsroot/ -</programlisting> - For full instructions, see the "rsync" section in the - <ulink url="http://pgfoundry.org/docman/view.php/1000040/4/PGBuildFarm-HOWTO.txt"> - PostgreSQL Build Farm instructions</ulink>. - </para> - </sect1> </appendix>
^ permalink raw reply [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 13:46  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Magnus Hagander <magnus@hagander.net>
  1 sibling, 1 reply; 20+ messages in thread

From: Tom Lane @ 2010-09-22 13:46 UTC (permalink / raw)
  To: Magnus Hagander <magnus@hagander.net>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

Magnus Hagander <magnus@hagander.net> writes:
> On Wed, Sep 22, 2010 at 00:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> A quick grep suggests that there are a dozen or two other passing
>> references to CVS in docs and comments, which'd be worth cleaning
>> up in HEAD, but probably not worth back-patching.

> Agreed.

> What about the messages in configure?
> "configure:*** Without Bison you will not be able to build PostgreSQL
> from CVS nor"

I was lumping those in the "not worth back-patching" category, but
if you're excited about them, feel free to back-patch.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 14:07  Magnus Hagander <magnus@hagander.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 20+ messages in thread

From: Magnus Hagander @ 2010-09-22 14:07 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

On Wed, Sep 22, 2010 at 15:46, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> On Wed, Sep 22, 2010 at 00:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> A quick grep suggests that there are a dozen or two other passing
>>> references to CVS in docs and comments, which'd be worth cleaning
>>> up in HEAD, but probably not worth back-patching.
>
>> Agreed.
>
>> What about the messages in configure?
>> "configure:*** Without Bison you will not be able to build PostgreSQL
>> from CVS nor"
>
> I was lumping those in the "not worth back-patching" category, but
> if you're excited about them, feel free to back-patch.

Ok. I'll see - I need to get an old version of autoconf going too - I
somehow managed to wipe the one I have, and Ubuntu ships with a
different version :-)

I take the lack of comment on the patch itself as silent approval, so
I'll go look at backporting it soon.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 14:10  Thom Brown <thom@linux.com>
  parent: Magnus Hagander <magnus@hagander.net>
  0 siblings, 1 reply; 20+ messages in thread

From: Thom Brown @ 2010-09-22 14:10 UTC (permalink / raw)
  To: Magnus Hagander <magnus@hagander.net>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-docs

On 22 September 2010 15:07, Magnus Hagander <magnus@hagander.net> wrote:
> On Wed, Sep 22, 2010 at 15:46, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Magnus Hagander <magnus@hagander.net> writes:
>>> On Wed, Sep 22, 2010 at 00:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>> A quick grep suggests that there are a dozen or two other passing
>>>> references to CVS in docs and comments, which'd be worth cleaning
>>>> up in HEAD, but probably not worth back-patching.
>>
>>> Agreed.
>>
>>> What about the messages in configure?
>>> "configure:*** Without Bison you will not be able to build PostgreSQL
>>> from CVS nor"
>>
>> I was lumping those in the "not worth back-patching" category, but
>> if you're excited about them, feel free to back-patch.
>
> Ok. I'll see - I need to get an old version of autoconf going too - I
> somehow managed to wipe the one I have, and Ubuntu ships with a
> different version :-)
>
> I take the lack of comment on the patch itself as silent approval, so
> I'll go look at backporting it soon.

I don't see any mention of redirecting the Heap-Only Tuples glossary
reference link.  Is that staying as it is?

-- 
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 14:20  Magnus Hagander <magnus@hagander.net>
  parent: Thom Brown <thom@linux.com>
  0 siblings, 0 replies; 20+ messages in thread

From: Magnus Hagander @ 2010-09-22 14:20 UTC (permalink / raw)
  To: Thom Brown <thom@linux.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-docs

On Wed, Sep 22, 2010 at 16:10, Thom Brown <thom@linux.com> wrote:
> On 22 September 2010 15:07, Magnus Hagander <magnus@hagander.net> wrote:
>> On Wed, Sep 22, 2010 at 15:46, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Magnus Hagander <magnus@hagander.net> writes:
>>>> On Wed, Sep 22, 2010 at 00:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>>> A quick grep suggests that there are a dozen or two other passing
>>>>> references to CVS in docs and comments, which'd be worth cleaning
>>>>> up in HEAD, but probably not worth back-patching.
>>>
>>>> Agreed.
>>>
>>>> What about the messages in configure?
>>>> "configure:*** Without Bison you will not be able to build PostgreSQL
>>>> from CVS nor"
>>>
>>> I was lumping those in the "not worth back-patching" category, but
>>> if you're excited about them, feel free to back-patch.
>>
>> Ok. I'll see - I need to get an old version of autoconf going too - I
>> somehow managed to wipe the one I have, and Ubuntu ships with a
>> different version :-)
>>
>> I take the lack of comment on the patch itself as silent approval, so
>> I'll go look at backporting it soon.
>
> I don't see any mention of redirecting the Heap-Only Tuples glossary
> reference link.  Is that staying as it is?

Ah, good point. No, let's change that.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 15:35  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Magnus Hagander <magnus@hagander.net>
  1 sibling, 1 reply; 20+ messages in thread

From: Tom Lane @ 2010-09-22 15:35 UTC (permalink / raw)
  To: Magnus Hagander <magnus@hagander.net>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

Magnus Hagander <magnus@hagander.net> writes:
>  <!-- appendixes -->
>  <!entity contacts   SYSTEM "contacts.sgml">
> -<!entity cvs        SYSTEM "cvs.sgml">
> +<!entity sourcerepo SYSTEM "sourcerepo.sgml">
>  <!entity datetime   SYSTEM "datetime.sgml">
>  <!entity docguide   SYSTEM "docguide.sgml">
>  <!entity errcodes   SYSTEM "errcodes.sgml">

Please keep the filelist entries in alphabetical order.

>     <!-- we need a file containing the CVS logs for each release, and something
>     like the SVN web interface that groups commits but has branches -->

This comment should be updated, or deleted entirely.

I didn't attempt to read the changes in sourcerepo.sgml ... as you well
know, I find diff -u format utterly unreadable for more than one-liner
changes.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 17:29  Magnus Hagander <magnus@hagander.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 2 replies; 20+ messages in thread

From: Magnus Hagander @ 2010-09-22 17:29 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

On Wed, Sep 22, 2010 at 17:35, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>>  <!-- appendixes -->
>>  <!entity contacts   SYSTEM "contacts.sgml">
>> -<!entity cvs        SYSTEM "cvs.sgml">
>> +<!entity sourcerepo SYSTEM "sourcerepo.sgml">
>>  <!entity datetime   SYSTEM "datetime.sgml">
>>  <!entity docguide   SYSTEM "docguide.sgml">
>>  <!entity errcodes   SYSTEM "errcodes.sgml">
>
> Please keep the filelist entries in alphabetical order.

Ack.


>>     <!-- we need a file containing the CVS logs for each release, and something
>>     like the SVN web interface that groups commits but has branches -->
>
> This comment should be updated, or deleted entirely.

Given that I don't even understand what it means and what it does
there, I deleted it :)


> I didn't attempt to read the changes in sourcerepo.sgml ... as you well
> know, I find diff -u format utterly unreadable for more than one-liner
> changes.

Sorry about that. It's basically just deleting all the references to
cvs - the git chapter was there already - and moving the info about
bison/flex/perl requirements to the first section.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 17:52  Magnus Hagander <magnus@hagander.net>
  parent: Magnus Hagander <magnus@hagander.net>
  1 sibling, 1 reply; 20+ messages in thread

From: Magnus Hagander @ 2010-09-22 17:52 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

On Wed, Sep 22, 2010 at 19:29, Magnus Hagander <magnus@hagander.net> wrote:
> On Wed, Sep 22, 2010 at 17:35, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Magnus Hagander <magnus@hagander.net> writes:
>> I didn't attempt to read the changes in sourcerepo.sgml ... as you well
>> know, I find diff -u format utterly unreadable for more than one-liner
>> changes.
>
> Sorry about that. It's basically just deleting all the references to
> cvs - the git chapter was there already - and moving the info about
> bison/flex/perl requirements to the first section.

Looking at backpatching this, I realized the major changes we made to
it a while ago was only backpatched to 8.4. 8.3 and earlier has the
much more complex cvs instructoins.

I suggest just wiping those and replacing them with the same git
instructions we have now. Objections?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 17:53  Alvaro Herrera <alvherre@commandprompt.com>
  parent: Magnus Hagander <magnus@hagander.net>
  1 sibling, 2 replies; 20+ messages in thread

From: Alvaro Herrera @ 2010-09-22 17:53 UTC (permalink / raw)
  To: Magnus Hagander <magnus@hagander.net>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Thom Brown <thom@linux.com>; pgsql-docs

Excerpts from Magnus Hagander's message of mié sep 22 13:29:00 -0400 2010:
> On Wed, Sep 22, 2010 at 17:35, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Magnus Hagander <magnus@hagander.net> writes:

> >>     <!-- we need a file containing the CVS logs for each release, and something
> >>     like the SVN web interface that groups commits but has branches -->
> >
> > This comment should be updated, or deleted entirely.
> 
> Given that I don't even understand what it means and what it does
> there, I deleted it :)

I think this is about having some sort of pointer to a ChangeLog or
similar resource (so that someone interested can see the commits for
each branch).  I didn't look at your patch, but if you provide a pointer
to the Git "summary", that seems enough.

BTW now that they are pestered with the PgFoundry commit messages, the
pgsql-committers archive do not seem a very useful resource anymore.
The Git "shortlog" seems much better, so maybe we should point to that.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 18:05  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Magnus Hagander <magnus@hagander.net>
  0 siblings, 1 reply; 20+ messages in thread

From: Tom Lane @ 2010-09-22 18:05 UTC (permalink / raw)
  To: Magnus Hagander <magnus@hagander.net>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

Magnus Hagander <magnus@hagander.net> writes:
> Looking at backpatching this, I realized the major changes we made to
> it a while ago was only backpatched to 8.4. 8.3 and earlier has the
> much more complex cvs instructoins.

> I suggest just wiping those and replacing them with the same git
> instructions we have now. Objections?

Works for me.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 18:07  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Alvaro Herrera <alvherre@commandprompt.com>
  1 sibling, 0 replies; 20+ messages in thread

From: Tom Lane @ 2010-09-22 18:07 UTC (permalink / raw)
  To: Alvaro Herrera <alvherre@commandprompt.com>; +Cc: Magnus Hagander <magnus@hagander.net>; Thom Brown <thom@linux.com>; pgsql-docs

Alvaro Herrera <alvherre@commandprompt.com> writes:
> BTW now that they are pestered with the PgFoundry commit messages, the
> pgsql-committers archive do not seem a very useful resource anymore.
> The Git "shortlog" seems much better, so maybe we should point to that.

Hmm ... do we have a search engine for the shortlog?  Anyway, anybody
who knows git at all will already know about looking at the git log.
I think the separate pointer to the committers archives is still of
use here.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 18:14  Magnus Hagander <magnus@hagander.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 20+ messages in thread

From: Magnus Hagander @ 2010-09-22 18:14 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

On Wed, Sep 22, 2010 at 20:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Looking at backpatching this, I realized the major changes we made to
>> it a while ago was only backpatched to 8.4. 8.3 and earlier has the
>> much more complex cvs instructoins.
>
>> I suggest just wiping those and replacing them with the same git
>> instructions we have now. Objections?
>
> Works for me.

Applied.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 18:25  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Magnus Hagander <magnus@hagander.net>
  0 siblings, 1 reply; 20+ messages in thread

From: Tom Lane @ 2010-09-22 18:25 UTC (permalink / raw)
  To: Magnus Hagander <magnus@hagander.net>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

Magnus Hagander <magnus@hagander.net> writes:
> On Wed, Sep 22, 2010 at 20:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Magnus Hagander <magnus@hagander.net> writes:
>>> I suggest just wiping those and replacing them with the same git
>>> instructions we have now. Objections?
>> 
>> Works for me.

> Applied.

Uh, why only back to 8.2?

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 18:28  Magnus Hagander <magnus@hagander.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 20+ messages in thread

From: Magnus Hagander @ 2010-09-22 18:28 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

On Wed, Sep 22, 2010 at 20:25, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> On Wed, Sep 22, 2010 at 20:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Magnus Hagander <magnus@hagander.net> writes:
>>>> I suggest just wiping those and replacing them with the same git
>>>> instructions we have now. Objections?
>>>
>>> Works for me.
>
>> Applied.
>
> Uh, why only back to 8.2?

Based on the "the others are discontinued just over a month from now anyway"...

BTW, there are a ton of conflicts backpatching each step. I actually
had a conflict with a $PostgreSQL$ tag once in the Makefile going back
to 8.4 - so that does happen. But only once - the rest is all "proper"
conflicts.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 18:37  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Magnus Hagander <magnus@hagander.net>
  0 siblings, 1 reply; 20+ messages in thread

From: Tom Lane @ 2010-09-22 18:37 UTC (permalink / raw)
  To: Magnus Hagander <magnus@hagander.net>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

Magnus Hagander <magnus@hagander.net> writes:
> On Wed, Sep 22, 2010 at 20:25, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Uh, why only back to 8.2?

> Based on the "the others are discontinued just over a month from now anyway"...

Yeah, but they will each have a final release.  Don't we want to have
the updated info in the final releases?  I don't care about the
incidental CVS mentions, but replacing cvs.sgml with that new chapter
seems worth the trouble.

> BTW, there are a ton of conflicts backpatching each step.

Welcome to the fun of back-patching.  Did you get any leverage from
cherry-picking, or did it seem to be just as stupid as plain "patch"?

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 18:42  Magnus Hagander <magnus@hagander.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 20+ messages in thread

From: Magnus Hagander @ 2010-09-22 18:42 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs

On Wed, Sep 22, 2010 at 20:37, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> On Wed, Sep 22, 2010 at 20:25, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Uh, why only back to 8.2?
>
>> Based on the "the others are discontinued just over a month from now anyway"...
>
> Yeah, but they will each have a final release.  Don't we want to have
> the updated info in the final releases?  I don't care about the
> incidental CVS mentions, but replacing cvs.sgml with that new chapter
> seems worth the trouble.

Hmm. yeah. I'll look at doing it back to 7.4 then. I'll do the
incidental mentions as well if they merge cleanly :-)


>> BTW, there are a ton of conflicts backpatching each step.
>
> Welcome to the fun of back-patching.  Did you get any leverage from

Oh, it's not the first time. I just wanted to make note that one, but
only one, conflicted on the $PostgreSQL$ tag.

> cherry-picking, or did it seem to be just as stupid as plain "patch"?

It *seemed* smarter. But I didn't try to backpatchthe same thing both
ways, so it's hard to tell for sure.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/



^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 20:08  Greg Smith <greg@2ndquadrant.com>
  parent: Alvaro Herrera <alvherre@commandprompt.com>
  1 sibling, 1 reply; 20+ messages in thread

From: Greg Smith @ 2010-09-22 20:08 UTC (permalink / raw)
  To: Alvaro Herrera <alvherre@commandprompt.com>; +Cc: Magnus Hagander <magnus@hagander.net>; Tom Lane <tgl@sss.pgh.pa.us>; Thom Brown <thom@linux.com>; pgsql-docs

Alvaro Herrera wrote:
> BTW now that they are pestered with the PgFoundry commit messages, the
> pgsql-committers archive do not seem a very useful resource anymore.
> The Git "shortlog" seems much better, so maybe we should point to that.
>   

I missed why that happened in the first place, but based on being a 
subscriber isn't that something that should be split onto another list 
regardless?  The chatter added to pgsql-committers from everything there 
really seems inappropriate.  A new pgsql-pgfoundry for all those instead 
perhaps?

-- 
Greg Smith, 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD
PostgreSQL Training, Services and Support  www.2ndQuadrant.us
Author, "PostgreSQL 9.0 High Performance"    Pre-ordering at:
https://www.packtpub.com/postgresql-9-0-high-performance/book




^ permalink  raw  reply  [nested|flat] 20+ messages in thread

* Re: CVS in docs
@ 2010-09-22 20:17  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Greg Smith <greg@2ndquadrant.com>
  0 siblings, 0 replies; 20+ messages in thread

From: Tom Lane @ 2010-09-22 20:17 UTC (permalink / raw)
  To: Greg Smith <greg@2ndquadrant.com>; +Cc: Alvaro Herrera <alvherre@commandprompt.com>; Magnus Hagander <magnus@hagander.net>; Thom Brown <thom@linux.com>; pgsql-docs

Greg Smith <greg@2ndquadrant.com> writes:
> Alvaro Herrera wrote:
>> BTW now that they are pestered with the PgFoundry commit messages, the
>> pgsql-committers archive do not seem a very useful resource anymore.
>> The Git "shortlog" seems much better, so maybe we should point to that.

> I missed why that happened in the first place, but based on being a 
> subscriber isn't that something that should be split onto another list 
> regardless?

IIRC, it was essentially a political decision, meant to help make
pgfoundry authors feel more like a part of the core project.  Personally
I filter the non-core commits separately anyway...

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 20+ messages in thread


end of thread, other threads:[~2010-09-22 20:17 UTC | newest]

Thread overview: 20+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-09-21 22:11 CVS in docs Thom Brown <thom@linux.com>
2010-09-21 22:38 ` Tom Lane <tgl@sss.pgh.pa.us>
2010-09-22 12:05   ` Magnus Hagander <magnus@hagander.net>
2010-09-22 13:46     ` Tom Lane <tgl@sss.pgh.pa.us>
2010-09-22 14:07       ` Magnus Hagander <magnus@hagander.net>
2010-09-22 14:10         ` Thom Brown <thom@linux.com>
2010-09-22 14:20           ` Magnus Hagander <magnus@hagander.net>
2010-09-22 15:35     ` Tom Lane <tgl@sss.pgh.pa.us>
2010-09-22 17:29       ` Magnus Hagander <magnus@hagander.net>
2010-09-22 17:52         ` Magnus Hagander <magnus@hagander.net>
2010-09-22 18:05           ` Tom Lane <tgl@sss.pgh.pa.us>
2010-09-22 18:14             ` Magnus Hagander <magnus@hagander.net>
2010-09-22 18:25               ` Tom Lane <tgl@sss.pgh.pa.us>
2010-09-22 18:28                 ` Magnus Hagander <magnus@hagander.net>
2010-09-22 18:37                   ` Tom Lane <tgl@sss.pgh.pa.us>
2010-09-22 18:42                     ` Magnus Hagander <magnus@hagander.net>
2010-09-22 17:53         ` Alvaro Herrera <alvherre@commandprompt.com>
2010-09-22 18:07           ` Tom Lane <tgl@sss.pgh.pa.us>
2010-09-22 20:08           ` Greg Smith <greg@2ndquadrant.com>
2010-09-22 20:17             ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox