From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Philipp Gramzow <phil@philphonic.de>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: incoorect restore_command
Date: Fri, 26 Feb 2021 14:42:03 +0900
Message-ID: <YDiKK883GvoSKj2z@paquier.xyz> (raw)
In-Reply-To: <06d9fc43-7ea9-20cc-191e-401136bc86fa@oss.nttdata.com>
References: <161397938841.15451.13129264141285167267@wrigleys.postgresql.org>
<YDXo2tIJmkW6mhkm@paquier.xyz>
<478b5b00-5ab3-a1b5-65f4-19b4409c720b@philphonic.de>
<YDYFuW+6Y72vRk9Q@paquier.xyz>
<3c8a08bb-3eaa-cdc6-08f9-3298342722c2@oss.nttdata.com>
<YDdJvgQIiBcF6JgR@paquier.xyz>
<06d9fc43-7ea9-20cc-191e-401136bc86fa@oss.nttdata.com>
On Thu, Feb 25, 2021 at 06:03:57PM +0900, Fujii Masao wrote:
> Regarding the section "Standalone Hot Backups", all the directories and
> file seem to be placed under /var/lib/pgsql, so at least for me it looks a bit
> strange to change only the path of archive directory. So I don't think that
> we need to do this change.
>
> -tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/
> +tar -rf /var/lib/pgsql/backup.tar /mnt/server/archivedir/
>
> Same as above.
Okay. I found the thing a bit inconsistent while looking at the whole
picture. Anyway, dropped those two parts.
> -archive_command = 'gzip < %p > /var/lib/pgsql/archive/%f'
> +archive_command = 'gzip < %p > /mnt/server/archivedir/%f.gz'
> </programlisting>
> You will then need to use <application>gunzip</application> during recovery:
> <programlisting>
> -restore_command = 'gunzip < /mnt/server/archivedir/%f > %p'
> +restore_command = 'gunzip < /mnt/server/archivedir/%f.gz > %p'
>
> LGTM. Thanks for the patch!
Thanks for the review. I have applied only this part, then.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, masao.fujii@oss.nttdata.com, phil@philphonic.de, pgsql-docs@lists.postgresql.org
Subject: Re: incoorect restore_command
In-Reply-To: <YDiKK883GvoSKj2z@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox