pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: myungkyu.lim <myungkyu.lim@samsung.com>
To: 'Michael Paquier' <michael@paquier.xyz>
Cc: 'Masahiko Sawada' <sawada.mshk@gmail.com>
Cc: 'PostgreSQL-development' <pgsql-hackers@postgresql.org>
Cc: woosung.sohn@samsung.com
Cc: don.hong@samsung.com
Subject: RE: [Todo item] Add entry creation timestamp column to pg_stat_replication
Date: Tue, 4 Dec 2018 16:24:25 +0900
Message-ID: <03f901d48ba2$6398d430$2aca7c90$@samsung.com> (raw)
In-Reply-To: <20181204060657.GA6859@paquier.xyz>
References: <CGME20181115080226epcas4p1f81c51691d9f12f7fa94c198e84edb3a@epcas4p1.samsung.com>
	<007701d47cb9$8f414380$adc3ca80$@samsung.com>
	<20181115082748.GG1374@paquier.xyz>
	<CAD21AoCgJ4asOa2qP5DQiyzHBJ+Dhhi8Z5kVVokS-R7HxsmtfA@mail.gmail.com>
	<20181122075321.GJ3369@paquier.xyz>
	<010201d4854b$ae87e510$0b97af30$@samsung.com>
	<20181129070020.GD2356@paquier.xyz>
	<00d401d487bf$98727c10$c9577430$@samsung.com>
	<20181130085415.GI2267@paquier.xyz>
	<20181204035625.GQ3423@paquier.xyz>
	<20181204060657.GA6859@paquier.xyz>

>> I have been looking at this patch more in-depth, and you missed one
>> critical thing: hot standby feedback messages also include the
>> timestamp the client used when sending the message, so if we want to
>> track the latest time when a message has been sent we should track it
>> as much as the timestamp from status update messages.
>>
>> Fixing that and updating a couple of comments and variables, I am
>> finishing with the attached.  Thoughts?

Thanks! I missed it..:(

>Another thing which is crossing my mind is if it would make sense to report
>the timestamp of the last HS feedback message and the timestamp of the last
>status update message into two separate columns.  As the point of this
>field is to help with the debugging of mostly idle systems it seems to me
>that merging both is fine, but I'd like to hear extra opinions about that.

I think purpose of this field, 
that react interval check and debugging on idle system.
So, merging both is better.
(Is 'Reply' and 'HSFeedback' worth measuring separately?)





view thread (22+ messages)  latest in thread

Message-ID: <03f901d48ba2$6398d430$2aca7c90$@samsung.com>
Permalink:  ../03f901d48ba2$6398d430$2aca7c90$@samsung.com/
Also on:    postgresql.org/message-id/03f901d48ba2$6398d430$2aca7c90$@samsung.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: myungkyu.lim@samsung.com, michael@paquier.xyz, sawada.mshk@gmail.com, woosung.sohn@samsung.com, don.hong@samsung.com
  Subject: RE: [Todo item] Add entry creation timestamp column to pg_stat_replication
  In-Reply-To: <03f901d48ba2$6398d430$2aca7c90$@samsung.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox