pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Getting rid of "unknown error" in dblink and postgres_fdw
Date: Thu, 22 Dec 2016 00:20:30 -0500
Message-ID: <12123.1482384030@sss.pgh.pa.us> (raw)
In-Reply-To: <3f3f5c79-acb3-5b4b-0e69-9563b9722b84@joeconway.com>
References: <19872.1482338965@sss.pgh.pa.us>
	<dfa45c48-659c-caa8-76de-06006707c3aa@joeconway.com>
	<21630.1482341251@sss.pgh.pa.us>
	<1312.1482343733@sss.pgh.pa.us>
	<02fa2d90-2efd-00bc-fefc-c23c00eb671e@joeconway.com>
	<19852.1482366129@sss.pgh.pa.us>
	<3f3f5c79-acb3-5b4b-0e69-9563b9722b84@joeconway.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Joe Conway <mail@joeconway.com> writes:
> On 12/21/2016 04:22 PM, Tom Lane wrote:
>> In short, yes, please copy that bit into dblink.

> The attached should do the trick I think.

I see that you need to pass the PGconn into dblink_res_error() now, but
what's the point of the new "bool fail" parameter?

> You think it is reasonable to backpatch this part too?

Yes, definitely.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (15+ messages)  latest in thread

Message-ID: <12123.1482384030@sss.pgh.pa.us>
Permalink:  ../12123.1482384030@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12123.1482384030@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mail@joeconway.com
  Subject: Re: Getting rid of "unknown error" in dblink and postgres_fdw
  In-Reply-To: <12123.1482384030@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox