pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Petr Jelinek <petr@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: adding partitioned tables to publications
Date: Sat, 04 Apr 2020 11:22:32 -0400
Message-ID: <13137.1586013752@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+HiwqGH+sh+0v9cgEnmU3qYycOJoj2Bo3D38F0hZz=4v96s5g@mail.gmail.com>
References: <CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ@mail.gmail.com>
	<b8f257af-3fcd-65b9-088c-0248d82e4e99@2ndquadrant.com>
	<CA+HiwqFZbbJzAZgTjqbRarp_xeqyymuNmGg8Q5tDKTZbk3=c2A@mail.gmail.com>
	<c0d69728-c3d8-ede8-ad31-941b2bbaff66@2ndquadrant.com>
	<CA+HiwqE+6gNgr-BVYeCMT38naRi9cJaanJb7+FCNsX9XgMwHsQ@mail.gmail.com>
	<CA+HiwqFjYE5anArxvkjr37AQMd52L-LZtz9Ld2QrLQ3YfcYhTw@mail.gmail.com>
	<CA+HiwqE+z2=wLv3a41h7JopcnUZAiFPeaiQyxZeGQ62QV3vsPQ@mail.gmail.com>
	<4f999141-97c8-c968-a726-0a1ec3e36e47@2ndquadrant.com>
	<ff6007b3-02c2-8296-2896-db99a51f57e2@2ndquadrant.com>
	<CA+HiwqGWXeBA2xagkz_YdxycmO38Vah_aviyJf_kC_kjCdL-Xg@mail.gmail.com>
	<CA+HiwqGkknVb+ccLVkgw1DoBYPzpuR43L+aT1eOT8dVEtiedtw@mail.gmail.com>
	<e934a27d-bab4-b818-8936-bbcd2d41df0a@2ndquadrant.com>
	<9684.1585929105@sss.pgh.pa.us>
	<13925.1585977907@sss.pgh.pa.us>
	<4f5a1798-9b23-f1fd-4b9e-67d0ea503e4c@2ndquadrant.com>
	<CA+HiwqGH+sh+0v9cgEnmU3qYycOJoj2Bo3D38F0hZz=4v96s5g@mail.gmail.com>

Amit Langote <amitlangote09@gmail.com> writes:
> One thing to I must clarify: coverage for most of pgoutput.c looks
> okay on each run.  I am concerned that the coverage for the code added
> by the patch is shown to be close to zero, which is a mystery to me,
> because I can confirm by other means such as debugging elogs() to next
> to the new code that the newly added tests do cover them.

According to

https://coverage.postgresql.org/src/backend/replication/pgoutput/index.html

the coverage is pretty good.  Maybe you're doing something wrong
in enabling coverage testing locally?

			regards, tom lane





view thread (86+ messages)  latest in thread

Message-ID: <13137.1586013752@sss.pgh.pa.us>
Permalink:  ../13137.1586013752@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/13137.1586013752@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amitlangote09@gmail.com, petr@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, rafia.pghackers@gmail.com
  Subject: Re: adding partitioned tables to publications
  In-Reply-To: <13137.1586013752@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox