From: Sergei Kornilov <sk@zsrv.org>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Ildar Musin <i.musin@postgrespro.ru>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
Date: Tue, 06 Mar 2018 21:32:08 +0300
Message-ID: <1715451520361128@web26o.yandex.ru> (raw)
In-Reply-To: <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
References: <880511520351578@web5j.yandex.ru>
<20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
Hello
> You should be able to use an event trigger that raises a message when
> table_rewrite is hit, to notify the test driver that a rewrite happens.
Here is no table rewrite, only verify. So here EventTriggerTableRewrite is not called. Or i missed something?
> ISTM that depending on DEBUG messages is bad because debugging lines
> added elsewhere will make your tests fail;
I agree and this is reason why i not used DEBUG message in tests as was proposed. I found INFO messages in tests and decided that this was an acceptable option year ago.
> and INFO is generally frowned upon (I, for one, would frown upon an INFO message raised by ALTER
> TABLE, for sure.) so let's not do that either.
In this case we need remove INFO from ALTER TABLE ATTACH PARTITION code and tests. I think is a bad idea of using different rules for same stuff, right? Probably i can do this work too.
But it is necessary to decide how the test should look.
regards, Sergei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sk@zsrv.org, alvherre@alvh.no-ip.org, i.musin@postgrespro.ru, sfrost@snowman.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
In-Reply-To: <1715451520361128@web26o.yandex.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox