pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ALTER TABLE on system catalogs
Date: Mon, 20 Aug 2018 09:34:50 -0400
Message-ID: <19365.1534772090@sss.pgh.pa.us> (raw)
In-Reply-To: <20180820125022.kh37mj7sxtaxeize@alap3.anarazel.de>
References: <e49f825b-fb25-0bc8-8afc-d5ad895c7975@2ndquadrant.com>
	<20180627203733.bfpibxdleimvwdg2@alap3.anarazel.de>
	<20180627230838.GI2667@paquier.xyz>
	<9fb22a98-fd64-1426-a4f4-b927ce1a9a5e@2ndquadrant.com>
	<920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com>
	<20180820023749.GD7403@paquier.xyz>
	<20180820104825.a7yryvlycwimgttf@alap3.anarazel.de>
	<b49018c4-6592-eece-f5db-5978fda1f5df@2ndquadrant.com>
	<20180820125022.kh37mj7sxtaxeize@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2018-08-20 14:38:25 +0200, Peter Eisentraut wrote:
>> Do you have an alternative in mind?

> One is to just not do anything. I'm not sure I'm on board with the goal
> of changing things to make DDL on system tables more palatable.

FWIW, I agree with doing as little as possible here.  I'd be on board
with Andres' suggestion of just swapping the two code stanzas so that
the no-op case doesn't error out.  As soon as you go beyond that, you
are in wildly unsafe and untested territory.

			regards, tom lane




view thread (25+ messages)  latest in thread

Message-ID: <19365.1534772090@sss.pgh.pa.us>
Permalink:  ../19365.1534772090@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19365.1534772090@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, peter.eisentraut@2ndquadrant.com, michael@paquier.xyz
  Subject: Re: ALTER TABLE on system catalogs
  In-Reply-To: <19365.1534772090@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox