From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Fetter <david@fetter.org>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@postgresql.org
Cc: daniel@yesql.se
Cc: michael@paquier.xyz
Subject: Re: Synchronize with imath upstream
Date: Sat, 16 Feb 2019 11:10:21 -0800
Message-ID: <20190216191021.GC1212026@rfd.leadboat.com> (raw)
In-Reply-To: <28536.1549601778@sss.pgh.pa.us>
References: <20190205234750.GA2774@alvherre.pgsql>
<FB934CD7-B508-4523-B920-F0EE9CCB1756@anarazel.de>
<23413.1549466124@sss.pgh.pa.us>
<20190207055011.GB392703@rfd.leadboat.com>
<19483.1549552325@sss.pgh.pa.us>
<20190208043844.GA562856@rfd.leadboat.com>
<28536.1549601778@sss.pgh.pa.us>
On Thu, Feb 07, 2019 at 11:56:18PM -0500, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Thu, Feb 07, 2019 at 10:12:05AM -0500, Tom Lane wrote:
> >> I have no particular opinion on whether pgindent should be part of the
> >> mix for imath, but I do strongly recommend setting up and documenting a
> >> reproducible import process, as I did for src/timezone.
>
> > Good idea. I've modified the imath.c header comment to take the form of an
> > import process; see attached imath1.29-pgedits-v2.patch.
>
> Maybe easier to keep the instructions in a separate README file?
Most imath.c patches have cause to update those lines, and patches to other
files almost never do. Hence, I think hackers are more likely to find and
update those lines in imath.c. I would choose a README if concerns weren't
concentrated in one file.
> (I don't see a need to put a PG copyright in this file, when the
> mods from upstream are this small.)
The tree has been inconsistent about that, which is okay. I was mimicking
src/port/strlcpy.c. Others, e.g. src/port/crypt.c, haven't added a copyright.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, andres@anarazel.de, alvherre@2ndquadrant.com, david@fetter.org, andrew@tao11.riddles.org.uk, daniel@yesql.se, michael@paquier.xyz
Subject: Re: Synchronize with imath upstream
In-Reply-To: <20190216191021.GC1212026@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox