From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improving isolationtester's data output
Date: Tue, 15 Jun 2021 20:43:23 -0700
Message-ID: <20210616034323.GA965392@rfd.leadboat.com> (raw)
In-Reply-To: <592938.1623807811@sss.pgh.pa.us>
References: <202106152320.xfiprkh4sp5c@alvherre.pgsql>
<583674.1623799585@sss.pgh.pa.us>
<20210616013115.2otscs7rwictsolv@alap3.anarazel.de>
<592938.1623807811@sss.pgh.pa.us>
On Tue, Jun 15, 2021 at 09:43:31PM -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2021-06-15 19:26:25 -0400, Tom Lane wrote:
> >> Going forward it wouldn't be a problem, but back-patching isolation
> >> test cases might find it annoying. On the other hand, my nearby
> >> patch to improve isolation test stability is already going to create
> >> issues of that sort. (Unless, dare I say it, we back-patch that.)
>
> > It might be worth to back-patch - aren't there some back branch cases of
> > test instability? And perhaps more importantly, I'm sure we'll encounter
> > cases of writing new isolation tests in the course of fixing bugs that
> > we'd want to backpatch that are hard to make reliable without the new
> > features?
>
> Yeah, there absolutely is a case to back-patch things like this. Whether
> it's a strong enough case, I dunno. I'm probably too close to the patch
> to have an unbiased opinion about that.
>
> However, a quick look through the commit history finds several places
> where we complained about not being able to back-patch isolation tests to
> before 9.6 because we hadn't back-patched that version's isolationtester
> improvements. I found 6b802cfc7, 790026972, c88411995, 8b21b416e without
> looking too hard. So that history certainly suggests that not
> back-patching such test infrastructure is the Wrong Thing.
I'm +1 for back-patching this class of change. I've wasted time adapting a
back-patch's test case to account for non-back-patched test infrastructure
changes. Every back-patch of test infrastructure has been a strict win from
my perspective.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, andres@anarazel.de, alvherre@alvh.no-ip.org
Subject: Re: Improving isolationtester's data output
In-Reply-To: <20210616034323.GA965392@rfd.leadboat.com>
References: <202106152320.xfiprkh4sp5c@alvherre.pgsql> <583674.1623799585@sss.pgh.pa.us> <20210616013115.2otscs7rwictsolv@alap3.anarazel.de> <592938.1623807811@sss.pgh.pa.us> <20210616034323.GA965392@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox