pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
out of date comment in commit_ts.c
4+ messages / 2 participants
[nested] [flat]

Commits from this thread:
  2022-08-09 670475b2fa  Fix obsolete comment in commit_ts.c.
* out of date comment in commit_ts.c
@ 2022-07-26 17:33 Nathan Bossart <nathandbossart@gmail.com>
  2022-07-27 20:29 ` Re: out of date comment in commit_ts.c Nathan Bossart <nathandbossart@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Nathan Bossart @ 2022-07-26 17:33 UTC (permalink / raw)
  To: pgsql-hackers

Hi hackers,

I noticed that commit_ts.c has the following comment:

 * XLOG interactions: this module generates an XLOG record whenever a new
 * CommitTs page is initialized to zeroes.  Also, one XLOG record is
 * generated for setting of values when the caller requests it; this allows
 * us to support values coming from places other than transaction commit.
 * Other writes of CommitTS come from recording of transaction commit in
 * xact.c, which generates its own XLOG records for these events and will
 * re-perform the status update on redo; so we need make no additional XLOG
 * entry here.

IIUC the ability for callers to request WAL record generation is no longer
possible as of 08aa89b [0].  Should the second sentence be removed?

[0] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=08aa89b

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: out of date comment in commit_ts.c
  2022-07-26 17:33 out of date comment in commit_ts.c Nathan Bossart <nathandbossart@gmail.com>
@ 2022-07-27 20:29 ` Nathan Bossart <nathandbossart@gmail.com>
  2022-08-09 01:02   ` Re: out of date comment in commit_ts.c Thomas Munro <thomas.munro@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Nathan Bossart @ 2022-07-27 20:29 UTC (permalink / raw)
  To: pgsql-hackers

On Tue, Jul 26, 2022 at 10:33:43AM -0700, Nathan Bossart wrote:
> IIUC the ability for callers to request WAL record generation is no longer
> possible as of 08aa89b [0].  Should the second sentence be removed?

Here's a patch.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachments:

fix_commit_ts_comment.patch (text/x-diff, 1.2K) download diff --git a/src/backend/access/transam/commit_ts.c b/src/backend/access/transam/commit_ts.c index 4dc8d402bd..9aa4675cb7 100644 --- a/src/backend/access/transam/commit_ts.c +++ b/src/backend/access/transam/commit_ts.c @@ -7,13 +7,10 @@ * for each transaction. * * XLOG interactions: this module generates an XLOG record whenever a new - * CommitTs page is initialized to zeroes. Also, one XLOG record is - * generated for setting of values when the caller requests it; this allows - * us to support values coming from places other than transaction commit. - * Other writes of CommitTS come from recording of transaction commit in - * xact.c, which generates its own XLOG records for these events and will - * re-perform the status update on redo; so we need make no additional XLOG - * entry here. + * CommitTs page is initialized to zeroes. Other writes of CommitTS come + * from recording of transaction commit in xact.c, which generates its own + * XLOG records for these events and will re-perform the status update on + * redo; so we need make no additional XLOG entry here. * * Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California
^ permalink raw reply [nested|flat] 4+ messages in thread

* Re: out of date comment in commit_ts.c
  2022-07-26 17:33 out of date comment in commit_ts.c Nathan Bossart <nathandbossart@gmail.com>
  2022-07-27 20:29 ` Re: out of date comment in commit_ts.c Nathan Bossart <nathandbossart@gmail.com>
@ 2022-08-09 01:02   ` Thomas Munro <thomas.munro@gmail.com>
  2022-08-09 03:29     ` Re: out of date comment in commit_ts.c Nathan Bossart <nathandbossart@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Thomas Munro @ 2022-08-09 01:02 UTC (permalink / raw)
  To: Nathan Bossart <nathandbossart@gmail.com>; +Cc: pgsql-hackers

On Thu, Jul 28, 2022 at 8:30 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
> On Tue, Jul 26, 2022 at 10:33:43AM -0700, Nathan Bossart wrote:
> > IIUC the ability for callers to request WAL record generation is no longer
> > possible as of 08aa89b [0].  Should the second sentence be removed?
>
> Here's a patch.

Pushed.





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: out of date comment in commit_ts.c
  2022-07-26 17:33 out of date comment in commit_ts.c Nathan Bossart <nathandbossart@gmail.com>
  2022-07-27 20:29 ` Re: out of date comment in commit_ts.c Nathan Bossart <nathandbossart@gmail.com>
  2022-08-09 01:02   ` Re: out of date comment in commit_ts.c Thomas Munro <thomas.munro@gmail.com>
@ 2022-08-09 03:29     ` Nathan Bossart <nathandbossart@gmail.com>
  0 siblings, 0 replies; 4+ messages in thread

From: Nathan Bossart @ 2022-08-09 03:29 UTC (permalink / raw)
  To: Thomas Munro <thomas.munro@gmail.com>; +Cc: pgsql-hackers

On Tue, Aug 09, 2022 at 01:02:15PM +1200, Thomas Munro wrote:
> Pushed.

Thanks!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2022-08-09 03:29 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 17:33 out of date comment in commit_ts.c Nathan Bossart <nathandbossart@gmail.com>
2022-07-27 20:29 ` Nathan Bossart <nathandbossart@gmail.com>
2022-08-09 01:02   ` Thomas Munro <thomas.munro@gmail.com>
2022-08-09 03:29     ` Nathan Bossart <nathandbossart@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox