pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedwindows cfbot failing: my_perl
17+ messages / 5 participants
[nested] [flat]
Commits from this thread:
2022-08-27 4eec2e03c3 Be more careful to avoid including system headers after perl.h
* windows cfbot failing: my_perl
@ 2022-08-26 11:55 Justin Pryzby <pryzby@telsasoft.com>
0 siblings, 1 reply; 17+ messages in thread
From: Justin Pryzby @ 2022-08-26 11:55 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
The last 20 some consecutive builds failed:
https://cirrus-ci.com/github/postgresql-cfbot/postgresql
like this:
[09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl': undeclared identifier (compiling source file src/pl/plperl/SPI.c) [c:\cirrus\plperl.vcxproj]
[09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl': undeclared identifier (compiling source file src/pl/plperl/Util.c) [c:\cirrus\plperl.vcxproj]
[09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2223: left of '->IMem' must point to struct/union (compiling source file src/pl/plperl/SPI.c) [c:\cirrus\plperl.vcxproj]
[09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2223: left of '->IMem' must point to struct/union (compiling source file src/pl/plperl/Util.c) [c:\cirrus\plperl.vcxproj]
I imagine it may be due to an error hit while rebuilding the ci's docker image.
--
Justin
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 13:21 Andres Freund <andres@anarazel.de>
parent: Justin Pryzby <pryzby@telsasoft.com>
0 siblings, 1 reply; 17+ messages in thread
From: Andres Freund @ 2022-08-26 13:21 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Hi,
On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> The last 20 some consecutive builds failed:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql
>
> like this:
> [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl': undeclared identifier (compiling source file src/pl/plperl/SPI.c) [c:\cirrus\plperl.vcxproj]
> [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl': undeclared identifier (compiling source file src/pl/plperl/Util.c) [c:\cirrus\plperl.vcxproj]
> [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2223: left of '->IMem' must point to struct/union (compiling source file src/pl/plperl/SPI.c) [c:\cirrus\plperl.vcxproj]
> [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2223: left of '->IMem' must point to struct/union (compiling source file src/pl/plperl/Util.c) [c:\cirrus\plperl.vcxproj]
>
> I imagine it may be due to an error hit while rebuilding the ci's docker image.
I don't think it's CI specific, see
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hamerkop&dt=2022-08-26%2011%3A00%3A11
Looks like the failures might have started with
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=121d2d3d70ecdb2113b340c5f3b99a6134129...
based on
https://cirrus-ci.com/github/postgres/postgres/
Not immediately obvious why that would be.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 13:40 Andres Freund <andres@anarazel.de>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 17+ messages in thread
From: Andres Freund @ 2022-08-26 13:40 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Hi,
On 2022-08-26 06:21:51 -0700, Andres Freund wrote:
> On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> > The last 20 some consecutive builds failed:
> > https://cirrus-ci.com/github/postgresql-cfbot/postgresql
> >
> > like this:
> > [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl': undeclared identifier (compiling source file src/pl/plperl/SPI.c) [c:\cirrus\plperl.vcxproj]
> > [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl': undeclared identifier (compiling source file src/pl/plperl/Util.c) [c:\cirrus\plperl.vcxproj]
> > [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2223: left of '->IMem' must point to struct/union (compiling source file src/pl/plperl/SPI.c) [c:\cirrus\plperl.vcxproj]
> > [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2223: left of '->IMem' must point to struct/union (compiling source file src/pl/plperl/Util.c) [c:\cirrus\plperl.vcxproj]
> >
> > I imagine it may be due to an error hit while rebuilding the ci's docker image.
>
> I don't think it's CI specific, see
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hamerkop&dt=2022-08-26%2011%3A00%3A11
>
> Looks like the failures might have started with
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=121d2d3d70ecdb2113b340c5f3b99a6134129...
> based on
> https://cirrus-ci.com/github/postgres/postgres/
>
> Not immediately obvious why that would be.
Reproduces in a VM, it starts to fail with that commit. Looks like somehow
different macros are trampling on each other. Something in perl is interfering
with msvc's malloc.h, turning
if (_Marker == _ALLOCA_S_HEAP_MARKER)
{
free(_Memory);
}
into
if (_Marker == 0xDDDD)
{
(*(my_perl->IMem)->pFree)((my_perl->IMem), (_Memory));
}
after preprocessing. No idea how.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 14:27 Andres Freund <andres@anarazel.de>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 17+ messages in thread
From: Andres Freund @ 2022-08-26 14:27 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Hi,
On 2022-08-26 06:40:47 -0700, Andres Freund wrote:
> On 2022-08-26 06:21:51 -0700, Andres Freund wrote:
> > On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> > > The last 20 some consecutive builds failed:
> > > https://cirrus-ci.com/github/postgresql-cfbot/postgresql
> > >
> > > like this:
> > > [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl': undeclared identifier (compiling source file src/pl/plperl/SPI.c) [c:\cirrus\plperl.vcxproj]
> > > [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl': undeclared identifier (compiling source file src/pl/plperl/Util.c) [c:\cirrus\plperl.vcxproj]
> > > [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2223: left of '->IMem' must point to struct/union (compiling source file src/pl/plperl/SPI.c) [c:\cirrus\plperl.vcxproj]
> > > [09:29:27.711] C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2223: left of '->IMem' must point to struct/union (compiling source file src/pl/plperl/Util.c) [c:\cirrus\plperl.vcxproj]
> > >
> > > I imagine it may be due to an error hit while rebuilding the ci's docker image.
> >
> > I don't think it's CI specific, see
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hamerkop&dt=2022-08-26%2011%3A00%3A11
> >
> > Looks like the failures might have started with
> > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=121d2d3d70ecdb2113b340c5f3b99a6134129...
> > based on
> > https://cirrus-ci.com/github/postgres/postgres/
> >
> > Not immediately obvious why that would be.
>
> Reproduces in a VM, it starts to fail with that commit. Looks like somehow
> different macros are trampling on each other. Something in perl is interfering
> with msvc's malloc.h, turning
>
> if (_Marker == _ALLOCA_S_HEAP_MARKER)
> {
> free(_Memory);
> }
> into
>
> if (_Marker == 0xDDDD)
> {
> (*(my_perl->IMem)->pFree)((my_perl->IMem), (_Memory));
> }
>
> after preprocessing. No idea how.
Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
causes issues when including system headers referencing free as well.
I don't really see a good solution to this other than hoisting the
mb/pg_wchar.h include out to before we include all the perl stuff. That does
fix the issue.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 14:39 John Naylor <john.naylor@enterprisedb.com>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 17+ messages in thread
From: John Naylor @ 2022-08-26 14:39 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
On Fri, Aug 26, 2022 at 9:27 PM Andres Freund <andres@anarazel.de> wrote:
>
> Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
> causes issues when including system headers referencing free as well.
>
> I don't really see a good solution to this other than hoisting the
> mb/pg_wchar.h include out to before we include all the perl stuff. That does
> fix the issue.
We could also move is_valid_ascii somewhere else. It's only
tangentially related to "wide chars" anyway.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 14:47 Andres Freund <andres@anarazel.de>
parent: John Naylor <john.naylor@enterprisedb.com>
0 siblings, 2 replies; 17+ messages in thread
From: Andres Freund @ 2022-08-26 14:47 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
Hi,
On 2022-08-26 21:39:05 +0700, John Naylor wrote:
> On Fri, Aug 26, 2022 at 9:27 PM Andres Freund <andres@anarazel.de> wrote:
> >
> > Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
> > causes issues when including system headers referencing free as well.
> >
> > I don't really see a good solution to this other than hoisting the
> > mb/pg_wchar.h include out to before we include all the perl stuff. That does
> > fix the issue.
>
> We could also move is_valid_ascii somewhere else. It's only
> tangentially related to "wide chars" anyway.
Given the crazy defines of stuff like free, it seems like a good idea to have
a rule that no headers should be included after plperl.h with
PG_NEED_PERL_XSUB_H defined. It's not like there's not other chances of of
pulling in malloc.h from within pg_wchar.h somehow.
It's a bit ugly to have the mb/pg_wchar.h in plperl.h instead of
plperl_helpers.h, but ...
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 20:28 Andres Freund <andres@anarazel.de>
parent: Andres Freund <andres@anarazel.de>
1 sibling, 1 reply; 17+ messages in thread
From: Andres Freund @ 2022-08-26 20:28 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; Tom Lane <tgl@sss.pgh.pa.us>; Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>; +Cc: Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
Hi,
Tom, Ilmari, you seem to have hacked on this stuff most (not so) recently. Do
you have a better suggestion than moving the mb/pg_wchar.h include out of
plperl_helpers.h as I suggest below?
On 2022-08-26 07:47:40 -0700, Andres Freund wrote:
> On 2022-08-26 21:39:05 +0700, John Naylor wrote:
> > On Fri, Aug 26, 2022 at 9:27 PM Andres Freund <andres@anarazel.de> wrote:
> > >
> > > Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
> > > causes issues when including system headers referencing free as well.
> > >
> > > I don't really see a good solution to this other than hoisting the
> > > mb/pg_wchar.h include out to before we include all the perl stuff. That does
> > > fix the issue.
> >
> > We could also move is_valid_ascii somewhere else. It's only
> > tangentially related to "wide chars" anyway.
>
> Given the crazy defines of stuff like free, it seems like a good idea to have
> a rule that no headers should be included after plperl.h with
> PG_NEED_PERL_XSUB_H defined. It's not like there's not other chances of of
> pulling in malloc.h from within pg_wchar.h somehow.
>
> It's a bit ugly to have the mb/pg_wchar.h in plperl.h instead of
> plperl_helpers.h, but ...
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 20:32 Tom Lane <tgl@sss.pgh.pa.us>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 17+ messages in thread
From: Tom Lane @ 2022-08-26 20:32 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: John Naylor <john.naylor@enterprisedb.com>; Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>; Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
Andres Freund <andres@anarazel.de> writes:
> Tom, Ilmari, you seem to have hacked on this stuff most (not so) recently. Do
> you have a better suggestion than moving the mb/pg_wchar.h include out of
> plperl_helpers.h as I suggest below?
I agree with the conclusion that we'd better #include all our own
headers before any of Perl's. No strong opinions about which
rearrangement is least ugly --- but let's add some comments about
that requirement.
regards, tom lane
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 21:05 Andrew Dunstan <andrew@dunslane.net>
parent: Andres Freund <andres@anarazel.de>
1 sibling, 1 reply; 17+ messages in thread
From: Andrew Dunstan @ 2022-08-26 21:05 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; John Naylor <john.naylor@enterprisedb.com>; +Cc: Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
On 2022-08-26 Fr 10:47, Andres Freund wrote:
> Hi,
>
> On 2022-08-26 21:39:05 +0700, John Naylor wrote:
>> On Fri, Aug 26, 2022 at 9:27 PM Andres Freund <andres@anarazel.de> wrote:
>>> Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
>>> causes issues when including system headers referencing free as well.
>>>
>>> I don't really see a good solution to this other than hoisting the
>>> mb/pg_wchar.h include out to before we include all the perl stuff. That does
>>> fix the issue.
>> We could also move is_valid_ascii somewhere else. It's only
>> tangentially related to "wide chars" anyway.
> Given the crazy defines of stuff like free, it seems like a good idea to have
> a rule that no headers should be included after plperl.h with
> PG_NEED_PERL_XSUB_H defined. It's not like there's not other chances of of
> pulling in malloc.h from within pg_wchar.h somehow.
>
> It's a bit ugly to have the mb/pg_wchar.h in plperl.h instead of
> plperl_helpers.h, but ...
>
It's already included directly in plperl.c, so couldn't we just lift it
directly into SPI.xs and Util.xs?
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-26 21:15 Andres Freund <andres@anarazel.de>
parent: Andrew Dunstan <andrew@dunslane.net>
0 siblings, 1 reply; 17+ messages in thread
From: Andres Freund @ 2022-08-26 21:15 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; +Cc: John Naylor <john.naylor@enterprisedb.com>; Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
Hi,
On 2022-08-26 17:05:52 -0400, Andrew Dunstan wrote:
> On 2022-08-26 Fr 10:47, Andres Freund wrote:
> > Given the crazy defines of stuff like free, it seems like a good idea to have
> > a rule that no headers should be included after plperl.h with
> > PG_NEED_PERL_XSUB_H defined. It's not like there's not other chances of of
> > pulling in malloc.h from within pg_wchar.h somehow.
> >
> > It's a bit ugly to have the mb/pg_wchar.h in plperl.h instead of
> > plperl_helpers.h, but ...
> It's already included directly in plperl.c, so couldn't we just lift it
> directly into SPI.xs and Util.xs?
I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
include in plperl.h would keep that aspect transparent, because plperl_utils.h
includes plperl.h.
I don't think manually including all dependencies, even if it's just one, in
each of the six files currently using plperl_utils.h is a good approach.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-27 02:32 John Naylor <john.naylor@enterprisedb.com>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 17+ messages in thread
From: John Naylor @ 2022-08-27 02:32 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Andrew Dunstan <andrew@dunslane.net>; Justin Pryzby <pryzby@telsasoft.com>; John Naylor <john.naylor@postgresql.org>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2022-08-26 17:05:52 -0400, Andrew Dunstan wrote:
> > On 2022-08-26 Fr 10:47, Andres Freund wrote:
> > > Given the crazy defines of stuff like free, it seems like a good idea to have
> > > a rule that no headers should be included after plperl.h with
> > > PG_NEED_PERL_XSUB_H defined. It's not like there's not other chances of of
> > > pulling in malloc.h from within pg_wchar.h somehow.
> > >
> > > It's a bit ugly to have the mb/pg_wchar.h in plperl.h instead of
> > > plperl_helpers.h, but ...
>
> > It's already included directly in plperl.c, so couldn't we just lift it
> > directly into SPI.xs and Util.xs?
>
> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
> include in plperl.h would keep that aspect transparent, because plperl_utils.h
> includes plperl.h.
Since plperl_helpers.h already includes plperl.h, I'm not sure why
both are included everywhere the former is. If .c/.xs files didn't
include plperl.h directly, we could keep pg_wchar.h in
plperl_helpers.h. Not sure if that's workable or any better...
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-27 03:02 Tom Lane <tgl@sss.pgh.pa.us>
parent: John Naylor <john.naylor@enterprisedb.com>
0 siblings, 2 replies; 17+ messages in thread
From: Tom Lane @ 2022-08-27 03:02 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: Andres Freund <andres@anarazel.de>; Andrew Dunstan <andrew@dunslane.net>; Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
John Naylor <john.naylor@enterprisedb.com> writes:
> On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <andres@anarazel.de> wrote:
>> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
>> include in plperl.h would keep that aspect transparent, because plperl_utils.h
>> includes plperl.h.
> Since plperl_helpers.h already includes plperl.h, I'm not sure why
> both are included everywhere the former is. If .c/.xs files didn't
> include plperl.h directly, we could keep pg_wchar.h in
> plperl_helpers.h. Not sure if that's workable or any better...
Maybe we should flush the separate plperl_helpers.h header and just
put those static-inline functions in plperl.h.
regards, tom lane
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-27 04:20 John Naylor <john.naylor@enterprisedb.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 17+ messages in thread
From: John Naylor @ 2022-08-27 04:20 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andres Freund <andres@anarazel.de>; Andrew Dunstan <andrew@dunslane.net>; Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
On Sat, Aug 27, 2022 at 10:02 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> John Naylor <john.naylor@enterprisedb.com> writes:
> > On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <andres@anarazel.de> wrote:
> >> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
> >> include in plperl.h would keep that aspect transparent, because plperl_utils.h
> >> includes plperl.h.
>
> > Since plperl_helpers.h already includes plperl.h, I'm not sure why
> > both are included everywhere the former is. If .c/.xs files didn't
> > include plperl.h directly, we could keep pg_wchar.h in
> > plperl_helpers.h. Not sure if that's workable or any better...
>
> Maybe we should flush the separate plperl_helpers.h header and just
> put those static-inline functions in plperl.h.
Here's a patch with that idea, not tested on Windows yet.
--
John Naylor
EDB: http://www.enterprisedb.com
Attachments:
v1-0001-Be-more-careful-to-avoid-including-system-headers.patch (text/x-patch, 12.9K) download
From b9fba2229b064ab3d7971917cf9bfc1f95bc2d6f Mon Sep 17 00:00:00 2001
From: John Naylor <john.naylor@postgresql.org>
Date: Sat, 27 Aug 2022 11:17:36 +0700
Subject: [PATCH v1] Be more careful to avoid including system headers after
perl.h
Commit 121d2d3d70 included simd.h into pg_wchar.h, which lead to perl.h's
free() being redefined, at least on Windows. To fix, move the static
inline function definitions from plperl_helpers.h, into plperl.h, where
we already document the necessary inclusion order. Since those functions
were the only reason for the existence of plperl_helpers.h, remove it.
First reported by Justin Pryzby
Diagnosis by Andres Freund, patch by myself per suggestion from Tom Lane
Discussion: https://www.postgresql.org/message-id/20220826115546.GE2342%40telsasoft.com
---
contrib/hstore_plperl/hstore_plperl.c | 1 -
contrib/jsonb_plperl/jsonb_plperl.c | 1 -
src/pl/plperl/GNUmakefile | 4 +-
src/pl/plperl/SPI.xs | 1 -
src/pl/plperl/Util.xs | 1 -
src/pl/plperl/plperl.c | 2 -
src/pl/plperl/plperl.h | 170 ++++++++++++++++++++++++-
src/pl/plperl/plperl_helpers.h | 171 --------------------------
8 files changed, 171 insertions(+), 180 deletions(-)
delete mode 100644 src/pl/plperl/plperl_helpers.h
diff --git a/contrib/hstore_plperl/hstore_plperl.c b/contrib/hstore_plperl/hstore_plperl.c
index c72785d99e..4a1629cad5 100644
--- a/contrib/hstore_plperl/hstore_plperl.c
+++ b/contrib/hstore_plperl/hstore_plperl.c
@@ -3,7 +3,6 @@
#include "fmgr.h"
#include "hstore/hstore.h"
#include "plperl.h"
-#include "plperl_helpers.h"
PG_MODULE_MAGIC;
diff --git a/contrib/jsonb_plperl/jsonb_plperl.c b/contrib/jsonb_plperl/jsonb_plperl.c
index 22e90afe1b..2af1e0c02a 100644
--- a/contrib/jsonb_plperl/jsonb_plperl.c
+++ b/contrib/jsonb_plperl/jsonb_plperl.c
@@ -4,7 +4,6 @@
#include "fmgr.h"
#include "plperl.h"
-#include "plperl_helpers.h"
#include "utils/fmgrprotos.h"
#include "utils/jsonb.h"
diff --git a/src/pl/plperl/GNUmakefile b/src/pl/plperl/GNUmakefile
index a2e6410f53..1ebf3c9ba2 100644
--- a/src/pl/plperl/GNUmakefile
+++ b/src/pl/plperl/GNUmakefile
@@ -72,7 +72,7 @@ XSUBPPDIR = $(shell $(PERL) -e 'use List::Util qw(first); print first { -r "$$_/
include $(top_srcdir)/src/Makefile.shlib
-plperl.o: perlchunks.h plperl_opmask.h plperl_helpers.h
+plperl.o: perlchunks.h plperl_opmask.h
plperl_opmask.h: plperl_opmask.pl
@if [ x"$(perl_privlibexp)" = x"" ]; then echo "configure switch --with-perl was not specified."; exit 1; fi
@@ -103,7 +103,7 @@ uninstall: uninstall-lib uninstall-data
install-data: installdirs
$(INSTALL_DATA) $(addprefix $(srcdir)/, $(DATA)) '$(DESTDIR)$(datadir)/extension/'
- $(INSTALL_DATA) $(srcdir)/plperl.h $(srcdir)/ppport.h $(srcdir)/plperl_helpers.h '$(DESTDIR)$(includedir_server)'
+ $(INSTALL_DATA) $(srcdir)/plperl.h $(srcdir)/ppport.h '$(DESTDIR)$(includedir_server)'
uninstall-data:
rm -f $(addprefix '$(DESTDIR)$(datadir)/extension'/, $(notdir $(DATA)))
diff --git a/src/pl/plperl/SPI.xs b/src/pl/plperl/SPI.xs
index b2db3bd694..e81432e634 100644
--- a/src/pl/plperl/SPI.xs
+++ b/src/pl/plperl/SPI.xs
@@ -13,7 +13,6 @@
/* perl stuff */
#define PG_NEED_PERL_XSUB_H
#include "plperl.h"
-#include "plperl_helpers.h"
MODULE = PostgreSQL::InServer::SPI PREFIX = spi_
diff --git a/src/pl/plperl/Util.xs b/src/pl/plperl/Util.xs
index 47eba59415..bb4580ebfa 100644
--- a/src/pl/plperl/Util.xs
+++ b/src/pl/plperl/Util.xs
@@ -20,7 +20,6 @@
/* perl stuff */
#define PG_NEED_PERL_XSUB_H
#include "plperl.h"
-#include "plperl_helpers.h"
static text *
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index af354a68cc..5d192a0ce5 100644
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -23,7 +23,6 @@
#include "commands/trigger.h"
#include "executor/spi.h"
#include "funcapi.h"
-#include "mb/pg_wchar.h"
#include "miscadmin.h"
#include "nodes/makefuncs.h"
#include "parser/parse_type.h"
@@ -47,7 +46,6 @@
/* string literal macros defining chunks of perl code */
#include "perlchunks.h"
#include "plperl.h"
-#include "plperl_helpers.h"
/* defines PLPERL_SET_OPMASK */
#include "plperl_opmask.h"
diff --git a/src/pl/plperl/plperl.h b/src/pl/plperl/plperl.h
index c662d17509..0c196ea046 100644
--- a/src/pl/plperl/plperl.h
+++ b/src/pl/plperl/plperl.h
@@ -3,7 +3,8 @@
* plperl.h
* Common include file for PL/Perl files
*
- * This should be included _AFTER_ postgres.h and system include files
+ * This should be included _AFTER_ postgres.h and system include files, as
+ * well as headers that could in turn include system headers.
*
* Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group
* Portions Copyright (c) 1995, Regents of the University of California
@@ -14,6 +15,9 @@
#ifndef PL_PERL_H
#define PL_PERL_H
+/* defines free() by way of system headers, so must be included before perl.h */
+#include "mb/pg_wchar.h"
+
/* stop perl headers from hijacking stdio and other stuff on Windows */
#ifdef WIN32
#define WIN32IO_IS_STDIO
@@ -213,4 +217,168 @@ void plperl_spi_rollback(void);
char *plperl_sv_to_literal(SV *, char *);
void plperl_util_elog(int level, SV *msg);
+
+/* helper functions */
+
+/*
+ * convert from utf8 to database encoding
+ *
+ * Returns a palloc'ed copy of the original string
+ */
+static inline char *
+utf_u2e(char *utf8_str, size_t len)
+{
+ char *ret;
+
+ ret = pg_any_to_server(utf8_str, len, PG_UTF8);
+
+ /* ensure we have a copy even if no conversion happened */
+ if (ret == utf8_str)
+ ret = pstrdup(ret);
+
+ return ret;
+}
+
+/*
+ * convert from database encoding to utf8
+ *
+ * Returns a palloc'ed copy of the original string
+ */
+static inline char *
+utf_e2u(const char *str)
+{
+ char *ret;
+
+ ret = pg_server_to_any(str, strlen(str), PG_UTF8);
+
+ /* ensure we have a copy even if no conversion happened */
+ if (ret == str)
+ ret = pstrdup(ret);
+
+ return ret;
+}
+
+/*
+ * Convert an SV to a char * in the current database encoding
+ *
+ * Returns a palloc'ed copy of the original string
+ */
+static inline char *
+sv2cstr(SV *sv)
+{
+ dTHX;
+ char *val,
+ *res;
+ STRLEN len;
+
+ /*
+ * get a utf8 encoded char * out of perl. *note* it may not be valid utf8!
+ */
+
+ /*
+ * SvPVutf8() croaks nastily on certain things, like typeglobs and
+ * readonly objects such as $^V. That's a perl bug - it's not supposed to
+ * happen. To avoid crashing the backend, we make a copy of the sv before
+ * passing it to SvPVutf8(). The copy is garbage collected when we're done
+ * with it.
+ */
+ if (SvREADONLY(sv) ||
+ isGV_with_GP(sv) ||
+ (SvTYPE(sv) > SVt_PVLV && SvTYPE(sv) != SVt_PVFM))
+ sv = newSVsv(sv);
+ else
+ {
+ /*
+ * increase the reference count so we can just SvREFCNT_dec() it when
+ * we are done
+ */
+ SvREFCNT_inc_simple_void(sv);
+ }
+
+ /*
+ * Request the string from Perl, in UTF-8 encoding; but if we're in a
+ * SQL_ASCII database, just request the byte soup without trying to make
+ * it UTF8, because that might fail.
+ */
+ if (GetDatabaseEncoding() == PG_SQL_ASCII)
+ val = SvPV(sv, len);
+ else
+ val = SvPVutf8(sv, len);
+
+ /*
+ * Now convert to database encoding. We use perl's length in the event we
+ * had an embedded null byte to ensure we error out properly.
+ */
+ res = utf_u2e(val, len);
+
+ /* safe now to garbage collect the new SV */
+ SvREFCNT_dec(sv);
+
+ return res;
+}
+
+/*
+ * Create a new SV from a string assumed to be in the current database's
+ * encoding.
+ */
+static inline SV *
+cstr2sv(const char *str)
+{
+ dTHX;
+ SV *sv;
+ char *utf8_str;
+
+ /* no conversion when SQL_ASCII */
+ if (GetDatabaseEncoding() == PG_SQL_ASCII)
+ return newSVpv(str, 0);
+
+ utf8_str = utf_e2u(str);
+
+ sv = newSVpv(utf8_str, 0);
+ SvUTF8_on(sv);
+ pfree(utf8_str);
+
+ return sv;
+}
+
+/*
+ * croak() with specified message, which is given in the database encoding.
+ *
+ * Ideally we'd just write croak("%s", str), but plain croak() does not play
+ * nice with non-ASCII data. In modern Perl versions we can call cstr2sv()
+ * and pass the result to croak_sv(); in versions that don't have croak_sv(),
+ * we have to work harder.
+ */
+static inline void
+croak_cstr(const char *str)
+{
+ dTHX;
+
+#ifdef croak_sv
+ /* Use sv_2mortal() to be sure the transient SV gets freed */
+ croak_sv(sv_2mortal(cstr2sv(str)));
+#else
+
+ /*
+ * The older way to do this is to assign a UTF8-marked value to ERRSV and
+ * then call croak(NULL). But if we leave it to croak() to append the
+ * error location, it does so too late (only after popping the stack) in
+ * some Perl versions. Hence, use mess() to create an SV with the error
+ * location info already appended.
+ */
+ SV *errsv = get_sv("@", GV_ADD);
+ char *utf8_str = utf_e2u(str);
+ SV *ssv;
+
+ ssv = mess("%s", utf8_str);
+ SvUTF8_on(ssv);
+
+ pfree(utf8_str);
+
+ sv_setsv(errsv, ssv);
+
+ croak(NULL);
+#endif /* croak_sv */
+}
+
#endif /* PL_PERL_H */
diff --git a/src/pl/plperl/plperl_helpers.h b/src/pl/plperl/plperl_helpers.h
deleted file mode 100644
index 1e318b6dc8..0000000000
--- a/src/pl/plperl/plperl_helpers.h
+++ /dev/null
@@ -1,171 +0,0 @@
-#ifndef PL_PERL_HELPERS_H
-#define PL_PERL_HELPERS_H
-
-#include "mb/pg_wchar.h"
-
-#include "plperl.h"
-
-
-/*
- * convert from utf8 to database encoding
- *
- * Returns a palloc'ed copy of the original string
- */
-static inline char *
-utf_u2e(char *utf8_str, size_t len)
-{
- char *ret;
-
- ret = pg_any_to_server(utf8_str, len, PG_UTF8);
-
- /* ensure we have a copy even if no conversion happened */
- if (ret == utf8_str)
- ret = pstrdup(ret);
-
- return ret;
-}
-
-/*
- * convert from database encoding to utf8
- *
- * Returns a palloc'ed copy of the original string
- */
-static inline char *
-utf_e2u(const char *str)
-{
- char *ret;
-
- ret = pg_server_to_any(str, strlen(str), PG_UTF8);
-
- /* ensure we have a copy even if no conversion happened */
- if (ret == str)
- ret = pstrdup(ret);
-
- return ret;
-}
-
-
-/*
- * Convert an SV to a char * in the current database encoding
- *
- * Returns a palloc'ed copy of the original string
- */
-static inline char *
-sv2cstr(SV *sv)
-{
- dTHX;
- char *val,
- *res;
- STRLEN len;
-
- /*
- * get a utf8 encoded char * out of perl. *note* it may not be valid utf8!
- */
-
- /*
- * SvPVutf8() croaks nastily on certain things, like typeglobs and
- * readonly objects such as $^V. That's a perl bug - it's not supposed to
- * happen. To avoid crashing the backend, we make a copy of the sv before
- * passing it to SvPVutf8(). The copy is garbage collected when we're done
- * with it.
- */
- if (SvREADONLY(sv) ||
- isGV_with_GP(sv) ||
- (SvTYPE(sv) > SVt_PVLV && SvTYPE(sv) != SVt_PVFM))
- sv = newSVsv(sv);
- else
- {
- /*
- * increase the reference count so we can just SvREFCNT_dec() it when
- * we are done
- */
- SvREFCNT_inc_simple_void(sv);
- }
-
- /*
- * Request the string from Perl, in UTF-8 encoding; but if we're in a
- * SQL_ASCII database, just request the byte soup without trying to make
- * it UTF8, because that might fail.
- */
- if (GetDatabaseEncoding() == PG_SQL_ASCII)
- val = SvPV(sv, len);
- else
- val = SvPVutf8(sv, len);
-
- /*
- * Now convert to database encoding. We use perl's length in the event we
- * had an embedded null byte to ensure we error out properly.
- */
- res = utf_u2e(val, len);
-
- /* safe now to garbage collect the new SV */
- SvREFCNT_dec(sv);
-
- return res;
-}
-
-/*
- * Create a new SV from a string assumed to be in the current database's
- * encoding.
- */
-static inline SV *
-cstr2sv(const char *str)
-{
- dTHX;
- SV *sv;
- char *utf8_str;
-
- /* no conversion when SQL_ASCII */
- if (GetDatabaseEncoding() == PG_SQL_ASCII)
- return newSVpv(str, 0);
-
- utf8_str = utf_e2u(str);
-
- sv = newSVpv(utf8_str, 0);
- SvUTF8_on(sv);
- pfree(utf8_str);
-
- return sv;
-}
-
-/*
- * croak() with specified message, which is given in the database encoding.
- *
- * Ideally we'd just write croak("%s", str), but plain croak() does not play
- * nice with non-ASCII data. In modern Perl versions we can call cstr2sv()
- * and pass the result to croak_sv(); in versions that don't have croak_sv(),
- * we have to work harder.
- */
-static inline void
-croak_cstr(const char *str)
-{
- dTHX;
-
-#ifdef croak_sv
- /* Use sv_2mortal() to be sure the transient SV gets freed */
- croak_sv(sv_2mortal(cstr2sv(str)));
-#else
-
- /*
- * The older way to do this is to assign a UTF8-marked value to ERRSV and
- * then call croak(NULL). But if we leave it to croak() to append the
- * error location, it does so too late (only after popping the stack) in
- * some Perl versions. Hence, use mess() to create an SV with the error
- * location info already appended.
- */
- SV *errsv = get_sv("@", GV_ADD);
- char *utf8_str = utf_e2u(str);
- SV *ssv;
-
- ssv = mess("%s", utf8_str);
- SvUTF8_on(ssv);
-
- pfree(utf8_str);
-
- sv_setsv(errsv, ssv);
-
- croak(NULL);
-#endif /* croak_sv */
-}
-
-#endif /* PL_PERL_HELPERS_H */
--
2.36.1
* Re: windows cfbot failing: my_perl
@ 2022-08-27 05:53 John Naylor <john.naylor@enterprisedb.com>
parent: John Naylor <john.naylor@enterprisedb.com>
0 siblings, 1 reply; 17+ messages in thread
From: John Naylor @ 2022-08-27 05:53 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andres Freund <andres@anarazel.de>; Andrew Dunstan <andrew@dunslane.net>; Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
On Sat, Aug 27, 2022 at 11:20 AM John Naylor
<john.naylor@enterprisedb.com> wrote:
>
> Here's a patch with that idea, not tested on Windows yet.
Update: I tried taking the CI for a spin, but ran into IT issues with
Github when I tried to push my branch to remote.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-27 07:11 Andres Freund <andres@anarazel.de>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 0 replies; 17+ messages in thread
From: Andres Freund @ 2022-08-27 07:11 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: John Naylor <john.naylor@enterprisedb.com>; Andrew Dunstan <andrew@dunslane.net>; Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
On 2022-08-26 23:02:06 -0400, Tom Lane wrote:
> John Naylor <john.naylor@enterprisedb.com> writes:
> > On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <andres@anarazel.de> wrote:
> >> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
> >> include in plperl.h would keep that aspect transparent, because plperl_utils.h
> >> includes plperl.h.
>
> > Since plperl_helpers.h already includes plperl.h, I'm not sure why
> > both are included everywhere the former is. If .c/.xs files didn't
> > include plperl.h directly, we could keep pg_wchar.h in
> > plperl_helpers.h. Not sure if that's workable or any better...
>
> Maybe we should flush the separate plperl_helpers.h header and just
> put those static-inline functions in plperl.h.
+1
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-27 07:23 Andres Freund <andres@anarazel.de>
parent: John Naylor <john.naylor@enterprisedb.com>
0 siblings, 1 reply; 17+ messages in thread
From: Andres Freund @ 2022-08-27 07:23 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Andrew Dunstan <andrew@dunslane.net>; Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
Hi,
On 2022-08-27 12:53:24 +0700, John Naylor wrote:
> On Sat, Aug 27, 2022 at 11:20 AM John Naylor
> <john.naylor@enterprisedb.com> wrote:
> >
> > Here's a patch with that idea, not tested on Windows yet.
>
> Update: I tried taking the CI for a spin, but ran into IT issues with
> Github when I tried to push my branch to remote.
A github, not a CI issue? Just making sure...
As a workaround you can just open a CF entry, that'll run the patch soon.
But either way, I ran the patch "manually" in a windows VM that I had running
anyway. With the meson patchset, but I don't see how it could matter here.
1/5 postgresql:setup / tmp_install OK 1.30s
2/5 postgresql:jsonb_plperl / jsonb_plperl/regress OK 8.30s
3/5 postgresql:bool_plperl / bool_plperl/regress OK 8.30s
4/5 postgresql:hstore_plperl / hstore_plperl/regress OK 8.64s
5/5 postgresql:plperl / plperl/regress OK 10.41s
Ok: 5
I didn't test other platforms.
WRT the patch's commit message: The issue isn't that perl's free() is
redefined, it's that perl's #define free (which references perl globals!)
breaks windows' header...
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 17+ messages in thread
* Re: windows cfbot failing: my_perl
@ 2022-08-27 07:36 John Naylor <john.naylor@enterprisedb.com>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 17+ messages in thread
From: John Naylor @ 2022-08-27 07:36 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Andrew Dunstan <andrew@dunslane.net>; Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers; Thomas Munro <thomas.munro@gmail.com>
On Sat, Aug 27, 2022 at 2:23 PM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2022-08-27 12:53:24 +0700, John Naylor wrote:
> > Update: I tried taking the CI for a spin, but ran into IT issues with
> > Github when I tried to push my branch to remote.
>
> A github, not a CI issue? Just making sure...
Yeah, I forked PG from the Github page, cloned it locally, applied the
patch and tried to push to origin.
> As a workaround you can just open a CF entry, that'll run the patch soon.
Yeah, I did that after taking a break -- there are compiler warnings
for contrib/sepgsql/label.c where pfree's argument is cast to void *,
so seems unrelated.
> But either way, I ran the patch "manually" in a windows VM that I had running
> anyway. With the meson patchset, but I don't see how it could matter here.
>
> 1/5 postgresql:setup / tmp_install OK 1.30s
> 2/5 postgresql:jsonb_plperl / jsonb_plperl/regress OK 8.30s
> 3/5 postgresql:bool_plperl / bool_plperl/regress OK 8.30s
> 4/5 postgresql:hstore_plperl / hstore_plperl/regress OK 8.64s
> 5/5 postgresql:plperl / plperl/regress OK 10.41s
>
> Ok: 5
>
>
> I didn't test other platforms.
>
>
> WRT the patch's commit message: The issue isn't that perl's free() is
> redefined, it's that perl's #define free (which references perl globals!)
> breaks windows' header...
Ah, thanks for that detail and for testing, will push.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 17+ messages in thread
end of thread, other threads:[~2022-08-27 07:36 UTC | newest]
Thread overview: 17+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26 11:55 windows cfbot failing: my_perl Justin Pryzby <pryzby@telsasoft.com>
2022-08-26 13:21 ` Andres Freund <andres@anarazel.de>
2022-08-26 13:40 ` Andres Freund <andres@anarazel.de>
2022-08-26 14:27 ` Andres Freund <andres@anarazel.de>
2022-08-26 14:39 ` John Naylor <john.naylor@enterprisedb.com>
2022-08-26 14:47 ` Andres Freund <andres@anarazel.de>
2022-08-26 20:28 ` Andres Freund <andres@anarazel.de>
2022-08-26 20:32 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-08-26 21:05 ` Andrew Dunstan <andrew@dunslane.net>
2022-08-26 21:15 ` Andres Freund <andres@anarazel.de>
2022-08-27 02:32 ` John Naylor <john.naylor@enterprisedb.com>
2022-08-27 03:02 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-08-27 04:20 ` John Naylor <john.naylor@enterprisedb.com>
2022-08-27 05:53 ` John Naylor <john.naylor@enterprisedb.com>
2022-08-27 07:23 ` Andres Freund <andres@anarazel.de>
2022-08-27 07:36 ` John Naylor <john.naylor@enterprisedb.com>
2022-08-27 07:11 ` Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox