pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Date: Fri, 30 Sep 2022 14:47:28 -0700
Message-ID: <20220930214728.GA177925@nathanxps13> (raw)
In-Reply-To: <678838.1664568924@sss.pgh.pa.us>
References: <20220920180533.GA205278@nathanxps13>
<20220920233117.GA378596@nathanxps13>
<20220920235010.GB378596@nathanxps13>
<Yyppg/c4SB7s1IAv@paquier.xyz>
<20220921043126.GA382738@nathanxps13>
<20220928185034.GA1397229@nathanxps13>
<CAOuzzgpQtdqj2BfwheD9+fjUnVSo1cmdrQmwcr-qbvKjC5cfyg@mail.gmail.com>
<20220928201222.GA1400058@nathanxps13>
<20220930192350.GA171832@nathanxps13>
<678838.1664568924@sss.pgh.pa.us>
On Fri, Sep 30, 2022 at 04:15:24PM -0400, Tom Lane wrote:
> In view of the recent mess around bigint relfilenodes, it seems to me
> that we shouldn't move forward with widening AclMode unless somebody
> runs down which structs will get wider (or more aligned) and how much
> that'll cost us. Maybe it's not a problem, but it could do with an
> explicit look at the point.
The main one I see is AclItem, which increases from 12 bytes to 16 bytes.
AFAICT all of the catalogs that store aclitem arrays have the aclitem[]
column marked extended, so they are compressed or moved out-of-line as
needed, too. The only other structs I've spotted that make use of AclMode
are InternalGrant and InternalDefaultACL. I haven't identified anything
that leads me to believe there are alignment problems or anything else
comparable to the issues listed in the relfilenode thread [0], but I could
be missing something. Did you have something else in mind you think ought
to be checked? I'm not sure my brief analysis here suffices.
[0] https://postgr.es/m/CA%2BTgmoaa9Yc9O-FP4vS_xTKf8Wgy8TzHpjnjN56_ShKE%3DjrP-Q%40mail.gmail.com
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
view thread (63+ messages) latest in thread
Message-ID: <20220930214728.GA177925@nathanxps13>
Permalink: ../20220930214728.GA177925@nathanxps13/
Also on: postgresql.org/message-id/20220930214728.GA177925@nathanxps13
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, sfrost@snowman.net, bharath.rupireddyforpostgres@gmail.com, david.g.johnston@gmail.com, horikyota.ntt@gmail.com, michael@paquier.xyz, robertmhaas@gmail.com
Subject: Re: predefined role(s) for VACUUM and ANALYZE
In-Reply-To: <20220930214728.GA177925@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox