From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: suggest to rename enable_incrementalsort
Date: Mon, 22 Jun 2020 12:16:34 -0400
Message-ID: <2079434.1592842594@sss.pgh.pa.us> (raw)
In-Reply-To: <20200622152219.GC28999@momjian.us>
References: <df652910-e985-9547-152c-9d4357dc3979@2ndquadrant.com>
<CAOBaU_bsOKEXgF_ik3bjAfV7HQAM+2MTbAwtKujqiu1YueeUiQ@mail.gmail.com>
<20200621112159.qtgedtrqw2c47pm4@development>
<CA+TgmoazhPwebpOwNbHt1vJoos1eLYhJVQPka+pptSLgS685aA@mail.gmail.com>
<2037457.1592836877@sss.pgh.pa.us>
<20200622152219.GC28999@momjian.us>
Bruce Momjian <bruce@momjian.us> writes:
> On Mon, Jun 22, 2020 at 10:41:17AM -0400, Tom Lane wrote:
>> Maybe I'm just used to the names, but I find that things like
>> "enable_seqscan" and "enable_nestloop" are pretty readable.
>> Once they get longer, though, not so much. So I agree with
>> renaming enable_incrementalsort.
> I think the big problem is that, without the extra underscore, it reads
> as increment-alsort. ;-)
Yeah, the longer the name gets, the harder it is to see where the
word boundaries are.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, robertmhaas@gmail.com, tomas.vondra@2ndquadrant.com, rjuju123@gmail.com, peter.eisentraut@2ndquadrant.com
Subject: Re: suggest to rename enable_incrementalsort
In-Reply-To: <2079434.1592842594@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox