From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
Date: Sun, 08 Sep 2019 19:44:16 -0400
Message-ID: <22859.1567986256@sss.pgh.pa.us> (raw)
In-Reply-To: <20190908233559.GA2467@paquier.xyz>
References: <6628.1567958876@sss.pgh.pa.us>
<5e1113b9-e1a6-d68b-c05c-06e607a4cd5f@2ndQuadrant.com>
<17551.1567979940@sss.pgh.pa.us>
<688d32cf-19be-c8f0-f08b-fde25d15132e@2ndQuadrant.com>
<18363.1567981113@sss.pgh.pa.us>
<20190908233559.GA2467@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> I think that it is a good idea to add in subdircheck an extra path to
> check after TAP tests and run optionally these on top of the normal
> regression tests. I have a couple of comments.
> Shouldn't we check after TAP_TESTS in the Makefile?
Yeah, perhaps, but I wasn't sure about how to do that easily.
Feel free to add it ...
> There is an argument to also check after isolation tests and run
> them.
Hm, yeah, if there are any such tests in those directories.
> The glob() part is a good idea in itself I think. Why not
> back-patching it? I could double-check it as well.
The whole thing should be back-patched into branches that have
any affected tests. (But, please, not till after beta4 is
tagged.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andrew.dunstan@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
In-Reply-To: <22859.1567986256@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox