pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgindent vs dtrace on macos
Date: Thu, 17 Sep 2020 14:20:28 -0400
Message-ID: <235128.1600366828@sss.pgh.pa.us> (raw)
In-Reply-To: <187727.1600357196@sss.pgh.pa.us>
References: <79ed5348-be7a-b647-dd40-742207186a22@2ndquadrant.com>
	<21042.1589983015@sss.pgh.pa.us>
	<fcbe3e68-19f8-ae3b-cf5a-3e420123826b@2ndquadrant.com>
	<FDCD46CA-C092-4B1D-B19E-314569AA3D88@yesql.se>
	<43461.1600300517@sss.pgh.pa.us>
	<2876D3E9-AD31-4841-869B-CADDBF2EBC66@yesql.se>
	<187727.1600357196@sss.pgh.pa.us>

I went ahead and added SPI.c, Util.c, and the *kwlist_d.h headers
to the exclusion list.  I then tried to run pgindent in a completely
built-out development directory (not distclean'ed, which is the way
I'd always used it before).  This found a few more exclusions we
need to have if we want to allow for that usage.  Pushed the lot.

We still have to deal with

src/backend/utils/sort/qsort_tuple.c
src/pl/plpgsql/src/plerrcodes.h
src/pl/plpython/spiexceptions.h
src/pl/tcl/pltclerrcodes.h

if we want to be entirely clean about this.

			regards, tom lane

view thread (21+ messages)  latest in thread

Message-ID: <235128.1600366828@sss.pgh.pa.us>
Permalink:  ../235128.1600366828@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/235128.1600366828@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, peter.eisentraut@2ndquadrant.com
  Subject: Re: pgindent vs dtrace on macos
  In-Reply-To: <235128.1600366828@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox