pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Steele <david@pgbackrest.org>
To: Benoit Lobréau <benoit.lobreau@dalibo.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix logging for invalid recovery timeline
Date: Mon, 24 Feb 2025 17:30:35 +0000 (UTC)
Message-ID: <26fd4e28-8b75-4e61-a3fd-aed3b7442606@pgbackrest.org> (raw)
In-Reply-To: <f0e04cf5-e7e3-4c16-9c7a-dc7a2aa2c069@dalibo.com>
References: <c3d617d4-1696-4aa7-8a4d-5a7d19cc5618@pgbackrest.org>
	<C748635E-B2FF-4813-B035-AE670832B9FD@yandex-team.ru>
	<d0b27c08-d30f-4a1d-990d-5c90ca0a650a@pgbackrest.org>
	<4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>
	<2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org>
	<Z7aJU2_ZAplbpTsL@paquier.xyz>
	<6273ef0b-033b-4ac7-ab05-71a04e7ac626@pgbackrest.org>
	<173a9a4a-bad3-4a42-91e1-637f70e9512f@dalibo.com>
	<5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org>
	<Z7vF1hyg5JOFTWst@paquier.xyz>
	<f0e04cf5-e7e3-4c16-9c7a-dc7a2aa2c069@dalibo.com>

On 2/24/25 10:21, Benoit Lobréau wrote:
> On 2/24/25 2:05 AM, Michael Paquier wrote:
>> I think that you have the right idea here, avoiding the duplication
>> of the errdetail() which feels itchy when looking at the patch. 
> 
> Done this way in the attached patch.

This looks good to me.

>> This should have a note for translators that this field refers to a file
>> name. 
> 
> Is there a specific way todo this?

If you search the source for translator: you'll find lots of examples. 
Here's one that was pretty relevant:

/* translator: %s is a configuration file */

We could probably phrase that as:

/* translator: %s is a backup_label or pg_control file */

That note goes right above the hint, so something like:

+                                /* translator: %s is a backup_label or 
pg_control file */
+				 errdetail("Latest checkpoint in %s is at %X/%X on timeline %u, but 
in the history of the requested timeline, the server forked off from 
that timeline at %X/%X.",
+						   haveBackupLabel ? "backup_label" : "pg_control",

Regards,
-David






view thread (16+ messages)  latest in thread

Message-ID: <26fd4e28-8b75-4e61-a3fd-aed3b7442606@pgbackrest.org>
Permalink:  ../26fd4e28-8b75-4e61-a3fd-aed3b7442606@pgbackrest.org/
Also on:    postgresql.org/message-id/26fd4e28-8b75-4e61-a3fd-aed3b7442606@pgbackrest.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgbackrest.org, benoit.lobreau@dalibo.com, michael@paquier.xyz, x4mmm@yandex-team.ru
  Subject: Re: Fix logging for invalid recovery timeline
  In-Reply-To: <26fd4e28-8b75-4e61-a3fd-aed3b7442606@pgbackrest.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox