From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
Date: Thu, 05 May 2022 23:36:22 -0400
Message-ID: <2823814.1651808182@sss.pgh.pa.us> (raw)
In-Reply-To: <20220506030927.6qehktk6bodv4ft3@alap3.anarazel.de>
References: <20220429200809.uuuseakmhb57sppk@alap3.anarazel.de>
<465685.1651274819@sss.pgh.pa.us>
<20220503014803.uknu3cwahwhbgrak@alap3.anarazel.de>
<1929823.1651549472@sss.pgh.pa.us>
<20220503040557.eimbfibv4rsey3s5@alap3.anarazel.de>
<1959496.1651555006@sss.pgh.pa.us>
<20220503182025.wvbebs2ojk6vpi5f@alap3.anarazel.de>
<2174975.1651602203@sss.pgh.pa.us>
<20220503191305.htuzje6ldmic7skk@alap3.anarazel.de>
<2808491.1651802860@sss.pgh.pa.us>
<20220506030927.6qehktk6bodv4ft3@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2022-05-05 22:07:40 -0400, Tom Lane wrote:
>> May I ask where we're at on this? Next week's back-branch release is
>> getting uncomfortably close, and I'm still seeing various buildfarm
>> animals erratically failing on 031_recovery_conflict.pl.
> Looks like the problems are gone on HEAD at least.
It does look that way, although the number of successes is not large yet.
>> Should we just remove that test from the back branches for now?
> That might be the best course, marking the test as TODO perhaps?
I poked closer and saw that you reverted 5136967f1 et al because
(I suppose) adjust_conf is not there in the back branches. While
I'd certainly support back-patching that functionality, I think
we need to have a discussion about how to do it. I wonder whether
we shouldn't drop src/test/perl/PostgreSQL/... into the back branches
in toto and make the old test APIs into a wrapper around the new ones
instead of vice versa. But that's definitely not a task to undertake
three days before a release deadline.
So I reluctantly vote for removing 031_recovery_conflict.pl in the
back branches for now, with the expectation that we'll fix the
infrastructure and put it back after the current release round
is done.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, thomas.munro@gmail.com, andrew@dunslane.net
Subject: Re: failures in t/031_recovery_conflict.pl on CI
In-Reply-To: <2823814.1651808182@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox