pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Mark Dilger <hornschnorter@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: WIP: BRIN multi-range indexes
Date: Mon, 25 Jun 2018 02:14:20 +0200
Message-ID: <2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com> (raw)
In-Reply-To: <6fd42b0c-b818-5889-c73e-bb2edcdde960@2ndquadrant.com>
References: <20180123200537.gfx5hxcp5k5hktpe@alvherre.pgsql>
	<821c4c1d-592e-8916-e323-04607b11777e@2ndquadrant.com>
	<c32f9f46-e0ca-0c02-45ec-718dd381f4be@2ndquadrant.com>
	<104E8BB8-35FF-4AA8-9871-6AFF04E4CAF3@gmail.com>
	<0afde2fc-e160-004f-8fe2-c65302ac3760@2ndquadrant.com>
	<22674.1517874015@sss.pgh.pa.us>
	<3e924a4c-6ca0-cc10-aebb-5004fc002800@2ndquadrant.com>
	<c2523129-a970-97f2-4705-a3b65e21b32f@2ndquadrant.com>
	<20180302035538.gkqgtcv6kmn2cklw@alap3.anarazel.de>
	<18526.1519963686@sss.pgh.pa.us>
	<1c1c1ced-1f79-a0ee-e5cd-858ca3eb9d74@2ndquadrant.com>
	<9b7551f2-93fb-3708-2705-35c42f0e6734@2ndquadrant.com>
	<4b0f4205-57b2-77d4-d500-510cbad25d7b@2ndquadrant.com>
	<459eef3e-48c7-0f5a-8356-992442a78bb6@2ndquadrant.com>
	<CAEepm=36WNm4dnbcW4w=Xt3nPSqH=y==WdeWc47zFzBfRARh1Q@mail.gmail.com>
	<6fd42b0c-b818-5889-c73e-bb2edcdde960@2ndquadrant.com>



On 06/25/2018 12:31 AM, Tomas Vondra wrote:
> On 06/24/2018 11:39 PM, Thomas Munro wrote:
>> On Sun, Jun 24, 2018 at 2:01 PM, Tomas Vondra
>> <tomas.vondra@2ndquadrant.com> wrote:
>>> Attached is rebased version of this BRIN patch series, fixing mostly the
>>> breakage due to 372728b0 (aka initial-catalog-data format changes). As
>>> 2018-07 CF is meant for almost-ready patches, this is more a 2018-09
>>> material. But perhaps someone would like to take a look - and I'd have
>>> to fix it anyway ...
>>
>> Hi Tomas,
>>
>> FYI Windows doesn't like this:
>>
>>   src/backend/access/brin/brin_bloom.c(146): warning C4013: 'round'
>> undefined; assuming extern returning int
>> [C:\projects\postgresql\postgres.vcxproj]
>>
>>   brin_bloom.obj : error LNK2019: unresolved external symbol round
>> referenced in function bloom_init
>> [C:\projects\postgresql\postgres.vcxproj]
>>
> 
> Thanks, I've noticed the failure before, but was not sure what's the
> exact cause. It seems there's still no 'round' on Windows, so I'll
> probably fix that by using rint() instead, or something like that.
> 

OK, here is a version tweaked to use floor()/ceil() instead of round().
Let's see if the Windows machine likes that more.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

  [application/gzip] 0001-Pass-all-keys-to-BRIN-consistent-function-a-20180625.patch.gz (5.4K, ../2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com/2-0001-Pass-all-keys-to-BRIN-consistent-function-a-20180625.patch.gz)
  download

  [application/gzip] 0002-Move-IS-NOT-NULL-checks-to-bringetbitmap-20180625.patch.gz (3.0K, ../2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com/3-0002-Move-IS-NOT-NULL-checks-to-bringetbitmap-20180625.patch.gz)
  download

  [application/gzip] 0003-BRIN-bloom-indexes-20180625.patch.gz (20.6K, ../2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com/4-0003-BRIN-bloom-indexes-20180625.patch.gz)
  download

  [application/gzip] 0004-BRIN-multi-range-minmax-indexes-20180625.patch.gz (29.6K, ../2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com/5-0004-BRIN-multi-range-minmax-indexes-20180625.patch.gz)
  download

view thread (177+ messages)  latest in thread

Message-ID: <2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com>
Permalink:  ../2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com/
Also on:    postgresql.org/message-id/2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, thomas.munro@enterprisedb.com, tgl@sss.pgh.pa.us, andres@anarazel.de, hornschnorter@gmail.com, alvherre@alvh.no-ip.org
  Subject: Re: WIP: BRIN multi-range indexes
  In-Reply-To: <2e8cdf94-eb53-e1fe-bc70-9f0a12f3b381@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox