pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Jelte Fennema <postgres@jeltef.nl>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Jesse Zhang <sbjesse@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Tue, 07 Feb 2023 10:17:44 -0500
Message-ID: <3083267.1675783064@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1JyWsqOihCk7q+iYs-f6JAvnr2TMBWej8HH9TLOpWTivQ@mail.gmail.com>
References: <CAGECzQTqoGHrePM_pwmhaM+J1XOygYjzFod4sf=PAt7J4A19Mw@mail.gmail.com>
	<2238493.1674572097@sss.pgh.pa.us>
	<Y9ArogF7c+UgPgq9@momjian.us>
	<20230129010603.GA1677550@rfd.leadboat.com>
	<Y9groc0Nyy7SOROy@momjian.us>
	<20230202062838.GA1832088@rfd.leadboat.com>
	<1477791.1675320029@sss.pgh.pa.us>
	<764a8f96-58c3-361d-428f-7ef827d62023@enterprisedb.com>
	<20230206212157.axnz62oagvycvcjm@awork3.anarazel.de>
	<2828975.1675719367@sss.pgh.pa.us>
	<20230207044324.GB2017197@rfd.leadboat.com>
	<1932eb97-7361-654e-fca5-817386f28306@dunslane.net>
	<CAA4eK1JyWsqOihCk7q+iYs-f6JAvnr2TMBWej8HH9TLOpWTivQ@mail.gmail.com>

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Feb 7, 2023 at 5:16 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>> On 2023-02-06 Mo 23:43, Noah Misch wrote:
>>>> Yeah.  I don't think we are seriously considering putting any restrictions
>>>> in place on gitmaster

>>> I could have sworn that was exactly what we were discussing, a pre-receive
>>> hook on gitmaster.

>> That's one idea that's been put forward, but it seems clear that some people are nervous about it.
>> Maybe a better course would be to continue improving the toolset and get more people comfortable with using it locally and then talk about integrating it upstream.

> Yeah, that sounds more reasonable to me as well.

+1.  Even if we end up with such a hook, we need to walk before we
can run.  The tooling of which we speak doesn't even exist today,
so it's unlikely to be bug-free, fast, and convenient to use
just two months from now.  Let's have some people use whatever
is proposed for awhile locally, and see what their experience is.

			regards, tom lane





view thread (308+ messages)  latest in thread

Message-ID: <3083267.1675783064@sss.pgh.pa.us>
Permalink:  ../3083267.1675783064@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3083267.1675783064@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, andrew@dunslane.net, noah@leadboat.com, peter.eisentraut@enterprisedb.com, andres@anarazel.de, bruce@momjian.us, postgres@jeltef.nl, pg@bowt.ie, magnus@hagander.net, alvherre@2ndquadrant.com, sfrost@snowman.net, sbjesse@gmail.com
  Subject: Re: run pgindent on a regular basis / scripted manner
  In-Reply-To: <3083267.1675783064@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox