From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Raúl Marín Rodríguez <rmrodriguez@carto.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date: Mon, 21 Jan 2019 11:10:22 -0500
Message-ID: <31298.1548087022@sss.pgh.pa.us> (raw)
In-Reply-To: <fde787ee-9c2d-46da-3ece-f7ae64a70b33@2ndQuadrant.com>
References: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
<29026.1547841766@sss.pgh.pa.us>
<32650.1547843169@sss.pgh.pa.us>
<CAM6_UM7fi-v5e90ghaZCLEfU4_Tk0n9=M6no5f1eXnMeLSeN0g@mail.gmail.com>
<20202.1548035461@sss.pgh.pa.us>
<alpine.DEB.2.21.1901210834280.2246@lancre>
<fde787ee-9c2d-46da-3ece-f7ae64a70b33@2ndQuadrant.com>
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> Perhaps it would be OK we changed back the glob line to use $prefix
> instead of $qprefix, but kept the use of $qprefix in the later regex.
Well, glob does have some metacharacters, so not doing any quoting
at all still leaves us with failure modes.
I did a little bit of googling on this subject last night, and it
seems that at least some people believe that the answer is to not
use glob, period, but read the directory for yourself. Maybe there's
a better way, but the breakage around backslashes doesn't really
leave me hopeful.
As a short-term move to un-break the buildfarm, I'm just going to
revert that patch altogether. We can reapply it once we've
figured out how to do the glob part correctly.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, coelho@cri.ensmp.fr, rmrodriguez@carto.com, alvherre@2ndquadrant.com
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
In-Reply-To: <31298.1548087022@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox