public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tomas Vondra <[email protected]>
To: Tom Lane <[email protected]>
To: David Rowley <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected]
Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
Date: Fri, 10 Jul 2026 02:05:43 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <bqqdehahpoa36igpictuqyn2s2mexk3t3ehidh2ffd2slb35e5@rzgksuiszgbg>
	<[email protected]>
	<ovpakrvg3mfwyumhkrxjgnwfb75jo534booip7pqrq7cjt4orj@vydvdlbscnx4>
	<CAH2-WznHSUJcV47OhoisvABjN2xjVOYh0_bRagUE6ir5zGJzow@mail.gmail.com>
	<[email protected]>
	<CAH2-Wzm3ev6uGsf4QddpaZamzsb3ATvanggEHxnhRSkdd52bnA@mail.gmail.com>
	<[email protected]>
	<CAApHDvpwjsxBYEsLLj5Z==zqZK4JZn2S_uc0Pi3dGACSsgOQyw@mail.gmail.com>
	<[email protected]>

On 7/9/26 02:14, Tom Lane wrote:
> David Rowley <[email protected]> writes:
>> On Thu, 9 Jul 2026 at 09:42, Tomas Vondra <[email protected]> wrote:
>>> I guess we should just commit that, so unless someone objects soon I'll
>>> just do that. ISTM the agreement is to backpatch this too.
> 
>> How about just backpatching the new macro and leaving the old one in
>> place back branches?
> 
> +1.  Breaking valid code in released branches is unfriendly.
> 

OK, that sounds reasonable. So in the backbranches we'd have both
pg_always_inline and the original pg_attriute_always_inline.

Does "backpatching the new macro" mean we'd also adjust all existing
places to use the new macro or not? I mean, we could backpatch just the
bit in c.h. I plan to adjust the places, to minimize possible conflicts
when backpatching other stuff.


regards

-- 
Tomas Vondra

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox