From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date: Tue, 13 Jul 2021 09:58:09 -0400
Message-ID: <3226452.1626184689@sss.pgh.pa.us> (raw)
In-Reply-To: <YO1GcUp9IPVU9wuJ@paquier.xyz>
References: <3185430.1626133592@sss.pgh.pa.us>
<YOzy2rlluWYYoUvW@paquier.xyz>
<3198753.1626150306@sss.pgh.pa.us>
<YO1GcUp9IPVU9wuJ@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Jul 13, 2021 at 12:25:06AM -0400, Tom Lane wrote:
>> That's easy enough in v13 and up, which have 8f4fb4c64 so that
>> Solution.pm looks like this. We could make it consistent in older
>> branches by manually hacking pg_config.h.win32 ... but I'm wondering
>> if the smarter plan wouldn't be to back-patch 8f4fb4c64.
> ... I am not sure that the potential maintenance gain is worth
> poking at the stable branches, to be honest.
Fair enough. I wasn't very eager to do the legwork on that, either,
given that the issue is (so far) only cosmetic.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, peter.eisentraut@enterprisedb.com
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
In-Reply-To: <3226452.1626184689@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox