pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: Improve logging when using Huge Pages
Date: Mon, 07 Nov 2022 10:56:16 -0500
Message-ID: <3239882.1667836576@sss.pgh.pa.us> (raw)
In-Reply-To: <20221107151458.6puzamerxti2y5in@awork3.anarazel.de>
References: <20211022023815.GI741@telsasoft.com>
	<TU4PR8401MB11529CCEE0FCC07EEE9F8FA7EE859@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<20211028220534.GB31568@telsasoft.com>
	<d928cc86-8e03-b481-18f7-2cb9c28fc724@oss.nttdata.com>
	<CAD21AoDrEma7ZGid2siYMDSa559O3Ox+N_D2B6vGwN5opqYr1w@mail.gmail.com>
	<TU4PR8401MB1152ECB9368A5CCC9AB0835DEE9F9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<d0a35f68-5d13-306c-f589-0ce816e952a5@timescale.com>
	<DM4PR84MB1734812E1690CD7BEB4B9C57EE9C9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
	<CA+hUKGJCZaeJX+z-qNnkgMW2B0FiqxfmaT7ALj7GwMRtNjjLog@mail.gmail.com>
	<CAFBsxsHKsdZjZfXVqxJMpFz4kFq82PsR1pKOEkGzLaeA6ONvnQ@mail.gmail.com>
	<20221107151458.6puzamerxti2y5in@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-11-06 14:04:29 +0700, John Naylor wrote:
>> I think the best thing to do is change huge_pages='on' to log a WARNING and
>> fallback to regular pages if the mapping fails.

> I am strongly opposed to making 'on' fall back to not using huge pages. That's
> what 'try' is for.

Agreed --- changing "on" to be exactly like "try" isn't an improvement.
If you want "try" semantics, choose "try".

			regards, tom lane





view thread (93+ messages)  latest in thread

Message-ID: <3239882.1667836576@sss.pgh.pa.us>
Permalink:  ../3239882.1667836576@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3239882.1667836576@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, john.naylor@enterprisedb.com, thomas.munro@gmail.com, noriyoshi.shinoda@hpe.com, jchampion@timescale.com, sawada.mshk@gmail.com, masao.fujii@oss.nttdata.com, pryzby@telsasoft.com, rjuju123@gmail.com, horikyota.ntt@gmail.com
  Subject: Re: Improve logging when using Huge Pages
  In-Reply-To: <3239882.1667836576@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox