pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: ArchiveEntry optional arguments refactoring
Date: Wed, 23 Jan 2019 13:33:09 -0500
Message-ID: <32742.1548268389@sss.pgh.pa.us> (raw)
In-Reply-To: <20190123173613.7jgxkiwxa5zzm2ww@alap3.anarazel.de>
References: <20190123164734.cnt7ho34ygwsav7z@alap3.anarazel.de>
	<201901231658.fls2whf2xypv@alvherre.pgsql>
	<20190123172328.b6trpdpcbzbq4unv@alap3.anarazel.de>
	<5606.1548264726@sss.pgh.pa.us>
	<20190123173613.7jgxkiwxa5zzm2ww@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> Btw, do you have an opionion on keeping catId / dumpId outside/inside
> the argument struct?

I'd go for outside, since they're not optional.  Not dead set on that
though.

			regards, tom lane

view thread (28+ messages)  latest in thread

Message-ID: <32742.1548268389@sss.pgh.pa.us>
Permalink:  ../32742.1548268389@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/32742.1548268389@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, alvherre@2ndquadrant.com, 9erthalion6@gmail.com, amitdkhan.pg@gmail.com
  Subject: Re: ArchiveEntry optional arguments refactoring
  In-Reply-To: <32742.1548268389@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox