pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Petr Jelinek <pjmodos@pjmodos.net>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Abhijit Menon-Sen <ams@toroid.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: GRANT ON ALL IN schema
Date: Mon, 12 Oct 2009 14:42:19 -0400
Message-ID: <343.1255372939@sss.pgh.pa.us> (raw)
In-Reply-To: <4AD14B31.5050309@pjmodos.net>
References: <4A37BF63.50008@pjmodos.net>
	<a301bfd90907170254re7dd52es9fedb007376d8055@mail.gmail.com>
	<4A6059B4.5010004@pjmodos.net>
	<4A607997.3030305@pjmodos.net>
	<21542.1249492707@sss.pgh.pa.us>
	<4A7F56A0.5060705@pjmodos.net>
	<4A7F5853.5010506@pjmodos.net>
	<20090920145011.GA24273@toroid.org>
	<4AB75A51.5060807@pjmodos.net>
	<603c8f070909270954n585e8e8am9eb1c187dec9fe19@mail.gmail.com>
	<3073cc9b0910100045qdcb2b3duabc05eb727ea0091@mail.gmail.com>
	<4AD14B31.5050309@pjmodos.net>

Petr Jelinek <pjmodos@pjmodos.net> writes:
> [ latest GRANT ALL patch ]

I started looking at this, and the first thing I noticed was that it
adds TABLES, FUNCTIONS, and SEQUENCES as unreserved keywords.  Now
I'm not a fan of bloating the parser that way, but I have to admit
that "GRANT ON ALL TABLE IN SCHEMA" wouldn't read well.  What I am
wondering is whether we should not go back and adjust the syntax
for the default-ACLs patch to use the same keywords, ie not

ALTER DEFAULT PRIVILEGES ... GRANT ... ON TABLE TO ...

but

ALTER DEFAULT PRIVILEGES ... GRANT ... ON TABLES TO ...

Comments?

			regards, tom lane

view thread (83+ messages)  latest in thread

Message-ID: <343.1255372939@sss.pgh.pa.us>
Permalink:  ../343.1255372939@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/343.1255372939@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pjmodos@pjmodos.net, jcasanov@systemguards.com.ec, robertmhaas@gmail.com, ams@toroid.org
  Subject: Re: GRANT ON ALL IN schema
  In-Reply-To: <343.1255372939@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox