public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Evan Jones <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Date: Tue, 20 Jun 2023 23:39:31 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <ZJI+G7B/qblD6/[email protected]>
References: <CA+HWA9bET27MxdO4VOgK==w4P_G9H0aStCq+C_DP4YnarAw87g@mail.gmail.com>
	<[email protected]>
	<CA+HWA9bTRDf52DHyU+JOoqEALgRGRo5uHUYTFuduoj3cBfer+Q@mail.gmail.com>
	<ZI5i2NCWirDuE/[email protected]>
	<[email protected]>
	<[email protected]>
	<ZI+TK2kch0ZZ/[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+HWA9ZRRxdL5FFTM4eTDyhmnzC-0tAo1kmu8Mndtjvs4O=G0Q@mail.gmail.com>
	<ZJI+G7B/qblD6/[email protected]>

Michael Paquier <[email protected]> writes:
> As a whole, I'd like to think that this is an improvement even for
> stable branches with these weird isspace() handlings, so I'm OK with
> the current status in all the branches.

Sounds like we're all content with that.

> There's an argument about \v,
> IMO, but I won't fight hard for it either even if it would be more
> consistent with the way array values are handled.

I'd be okay with adding \v to the set of whitespace characters in
scan.l and scanner_isspace (and other affected places) for v17.
Don't want to back-patch it though.

			regards, tom lane

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox