public inbox for [email protected]
help / color / mirror / Atom feedFrom: Chao Li <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Rafia Sabih <[email protected]>
Cc: vignesh C <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Set notice receiver before libpq connection startup
Date: Thu, 28 May 2026 13:46:45 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwHBPqis=pP7ui-x1vNboG5dGHkieVJoEbZfEkFgNnU1Zw@mail.gmail.com>
References: <[email protected]>
<CAHGQGwHnz7FoSx+qQsAHBx_j8Tks+SC-kAPTevrKYfrL08Ee9Q@mail.gmail.com>
<[email protected]>
<CALDaNm3UyoQ91gW2bRP4PXnnfAv3GfmCik614-AtQCiEUAjQYw@mail.gmail.com>
<[email protected]>
<CA+FpmFdfyBhuiou1uqe94UR3WCg57wM5FsooUx2w27aABGoyag@mail.gmail.com>
<CAHGQGwHU2E7h7XBCBNK7OJ+OAx7Xkwn+yUb7o5p5GxExi4fzAw@mail.gmail.com>
<[email protected]>
<CAHGQGwEvA2a+jXZdVrdybX9OmWguSU4Q8wEhZxWKkDMOZHnuMQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CAHGQGwHBPqis=pP7ui-x1vNboG5dGHkieVJoEbZfEkFgNnU1Zw@mail.gmail.com>
> On May 28, 2026, at 13:22, Fujii Masao <[email protected]> wrote:
>
> On Thu, May 28, 2026 at 9:40 AM Chao Li <[email protected]> wrote:
>>> The committed patch violates the .gitattributes whitespace rules:
>>>
>>> git show --check 06a5c3cdef02
>>>
>>> contrib/postgres_fdw/connection.c:651: indent with spaces.
>>> + /* expand_dbname = */ false);
>>>
>>> It is unfortunate that pgindent produces this layout that contradicts the git configuration. (The current formatting also doesn't look like what I would produce in an editor, so I think git is right here.)
>>>
>>> Maybe we could reformat this slightly to avoid that? (unless someone wants to try to fix pgindent)
>
> Thanks for the report!
>
>
>> Ah, I was not aware of the whitespace rule. I think it was not pgindent; I made that change manually. I added “=” because I thought it might read more fluently.
>>
>> Attached is a fix for that.
>
> Thanks for the patch!
>
> I suspect the whitespace issue was caused by pgindent that I ran
> before committing the patch.
>
> - /* expand_dbname = */ false);
> + false /* expand_dbname */ );
>
> I think "/* expand_dbname = */ false" looks better. libpqwalreceiver.c
> also uses that comment style. So how about the attached v2 patch, which
> reformats the comment accordingly?
>
> After applying the v2 patch, I confirmed that neither "git show --check ..."
> nor pgindent reports any issues.
>
> Regards,
>
> --
> Fujii Masao
> <v2-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch>
Oh, I misunderstood the problem. Nice to learn a new thing, I never knew git show check before. Yes, v2 passed “git show --check d359d02a238”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Set notice receiver before libpq connection startup
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox