pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter_e@gmx.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: cedric@2ndquadrant.com, pgsql-hackers@postgresql.org, Josh Berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Thu, 04 Dec 2014 16:10:02 -0500
Message-ID: <5480CDAA.4020203@dunslane.net> (raw)
In-Reply-To: <5480C846.6090302@dunslane.net>
References: <51DB171F.2090108@dunslane.net>
	<201307122350.23726.cedric@2ndquadrant.com>
	<1739933.FyLmpy7Q73@obelix>
	<5248B32E.1090001@dunslane.net>
	<1381193255.25702.4.camel@vanquo.pezone.net>
	<525410EC.9010002@dunslane.net>
	<1381455307.5264.14.camel@vanquo.pezone.net>
	<525769CE.3010201@dunslane.net>
	<20140201021908.GA24521@momjian.us>
	<52EC5BB6.6060305@dunslane.net>
	<20140201022855.GB31141@momjian.us>
	<546D6A0E.9080608@gmx.net>
	<54808E1A.1070208@gmx.net>
	<5480B9BB.6060301@gmx.net>
	<5480C846.6090302@dunslane.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>


On 12/04/2014 03:47 PM, Andrew Dunstan wrote:
>
> On 12/04/2014 02:44 PM, Peter Eisentraut wrote:
>> On 12/4/14 11:38 AM, Peter Eisentraut wrote:
>>> On 11/19/14 11:11 PM, Peter Eisentraut wrote:
>>>> I noticed this item was still in the 9.4 code.  Looking at the 
>>>> original
>>>> submission
>>>> (http://www.postgresql.org/message-id/201306181552.36673.cedric@2ndquadrant.com, 
>>>>
>>>> patch 0001), I think the original reason for adding this was wrong to
>>>> begin with.
>>> I have applied all three patches to 9.4 and 9.5.  So this issue is now
>>> resolved.
>> Apparently, some buildfarm module is unhappy with this:
>>
>> http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=sittella&dt=2014-12-04%2017%3A16%3A... 
>>
>>
>> Is there some custom code running there?  I don't know how that error
>> would happen otherwise?
>>
>>
>
>
> You have broken two buildfarm instances that build and test external 
> modules - in one case the Redis FDW module and in the other the File 
> Text Array FDW. I will see what can be retrieved.
>
>



I think this needs to be reverted. This has broken two modules that are 
not even using vpath builds.

You can see the relevant Makefiles at: 
<https://github.com/adunstan/file_text_array_fdw/blob/master/Makefile; 
and <https://github.com/pg-redis-fdw/redis_fdw/blob/master/Makefile;.

IIRC, the code you found convoluted and removed was required precisely 
to prevent this sort of error.

cheers

andrew



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (68+ messages)  latest in thread

Message-ID: <5480CDAA.4020203@dunslane.net>
Permalink:  ../5480CDAA.4020203@dunslane.net/
Also on:    postgresql.org/message-id/5480CDAA.4020203@dunslane.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew@dunslane.net, peter_e@gmx.net, bruce@momjian.us, josh@agliodbs.com, robertmhaas@gmail.com, craig@2ndquadrant.com
  Subject: Re: Bugfix and new feature for PGXS
  In-Reply-To: <5480CDAA.4020203@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox