From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Vik Fearing <vik.fearing@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add %x to PROMPT1 and PROMPT2
Date: Mon, 03 Feb 2020 09:40:01 -0500
Message-ID: <6749.1580740801@sss.pgh.pa.us> (raw)
In-Reply-To: <5E008326-2335-4FB2-8513-D9018EC94F02@yesql.se>
References: <09502c40-cfe1-bb29-10f9-4b3fa7b2bbb2@2ndquadrant.com>
<alpine.DEB.2.21.2001261946530.29788@pseudo>
<e04078e8-ae4a-b09d-896d-5f2f5a042248@2ndquadrant.com>
<alpine.DEB.2.21.2001271250190.24374@pseudo>
<13bc9081-2cf8-bf99-bedb-ce70c82bebc8@2ndquadrant.com>
<20200203070807.GD2180@paquier.xyz>
<5E008326-2335-4FB2-8513-D9018EC94F02@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
> On 3 Feb 2020, at 08:08, Michael Paquier <michael@paquier.xyz> wrote:
>> FWIW, I am not really in favor of changing a default old enough that
>> it could vote (a45195a).
> That by itself doesn't seem a good reason to not change things.
> My concern would be that users who have never ever considered that the prompt
> can be changed, all of sudden wonder why the prompt is showing characters it
> normally isn't, thus causing confusion. That being said, I agree that this is
> a better default long-term.
I've got the same misgivings as Michael. In a green field this'd likely
be a good idea, but after so many years I'm afraid it will make fewer
people happy than unhappy.
Now on the other hand, we did change the server's default log_line_prefix
not so long ago (7d3235ba4), and the feared storm of complaints was pretty
much undetectable. So maybe this'd go down the same way. Worth noting
also is that this shouldn't be able to break any applications, since the
prompt is an interactive-only behavior.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, michael@paquier.xyz, vik.fearing@2ndquadrant.com, coelho@cri.ensmp.fr
Subject: Re: Add %x to PROMPT1 and PROMPT2
In-Reply-To: <6749.1580740801@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox