From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: HEAPDEBUGALL is broken
Date: Wed, 22 Apr 2020 10:19:51 -0400
Message-ID: <6830.1587565191@sss.pgh.pa.us> (raw)
In-Reply-To: <8936216c-3492-3f6e-634b-d638fddc5f91@gmail.com>
References: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
<3070eb7d-e06d-31a0-5b68-4ae088fd146c@gmail.com>
<cffb7d94-e7f4-6d45-bd0b-7cca9e2796fb@2ndquadrant.com>
<8936216c-3492-3f6e-634b-d638fddc5f91@gmail.com>
Alexander Lakhin <exclusion@gmail.com> writes:
> 21.04.2020 21:01, Peter Eisentraut wrote:
>> Do you have a proposed patch?
> As this is broken at least since the invention of the generational
> allocator (2017-11-23, a4ccc1ce), I believe than no one uses this (and
> slab is broken too). Nonetheless, HAVE_ALLOCINFO in aset.c is still
> working, so it could be leaved alone, though the output too chatty for
> general use (`make check` produces postmaster log of size 3.8GB). I
> think someone would still need to insert some extra conditions to use
> that or find another way to debug memory allocations.
> So I would just remove this debug macro. The proposed patch is attached.
I didn't review this in close detail, but I think it's a good idea.
We have better memory-use-analysis tools these days, such as valgrind,
so it's no surprise that nobody is using this old code.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, exclusion@gmail.com, peter.eisentraut@2ndquadrant.com
Subject: Re: HEAPDEBUGALL is broken
In-Reply-To: <6830.1587565191@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox