public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Nitin Motiani <[email protected]>
Cc: Hannu Krosing <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
Date: Mon, 14 Jul 2025 13:28:03 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <aHUvLi_sdfBrxzYh@nathan>
References: <CAMT0RQTXiqH7zdQEVSVd2L7_Cw4wQ1eHOD8hfZ+0vecMXJWc-w@mail.gmail.com>
<aG2ISJC__3lQwRqY@nathan>
<CAMT0RQStPtHfKwowd88Q0tynX0x=uJSKn=ihP8syhDJ6cH3DHQ@mail.gmail.com>
<aG6srPib60NzJBeg@nathan>
<CAMT0RQRT3KkwoQkx=YBdd_o9SqXxOt16fqQsscH_n+40Z57N7w@mail.gmail.com>
<CAH5HC942o6j1qyVysiBtO+Vpb=XOBPbf3rKqsOLtpDpp0SzjkA@mail.gmail.com>
<aHAzv9pgJh2Wa3M1@nathan>
<CAH5HC94tYpgCnoPRYbCGQU0eCM8D7X+aEmB0GZrhjR16JEe5_A@mail.gmail.com>
<aHEk_JEoNhIpuHd-@nathan>
<CAH5HC96=3NjeYA5vuj8CyMmiFhU27jgvQ9WgXbUDccrE7xvwYw@mail.gmail.com>
<aHUvLi_sdfBrxzYh@nathan>
Nathan Bossart <[email protected]> writes:
> Here is what I have staged for commit, which (barring feedback or
> objections) I am planning to do towards the end of the week.
Is it intentional that this does
+#include "catalog/pg_largeobject_metadata.h"
+#include "catalog/pg_shdepend.h"
rather than including the corresponding *_d.h headers?
If so, why? Our normal coding convention is that frontend
code should only include catalog *_d.h files, since the main
headers might contain frontend-unfriendly declarations.
If there is something we need to expose in these catalogs'
*_d.h headers, we should probably do that.
regards, tom lane
view thread (46+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox