public inbox for [email protected]  
help / color / mirror / Atom feed
From: Nathan Bossart <[email protected]>
To: Nitin Motiani <[email protected]>
Cc: Hannu Krosing <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
Date: Thu, 10 Jul 2025 16:42:23 -0500
Message-ID: <aHAzv9pgJh2Wa3M1@nathan> (raw)
In-Reply-To: <CAH5HC942o6j1qyVysiBtO+Vpb=XOBPbf3rKqsOLtpDpp0SzjkA@mail.gmail.com>
References: <Z_VTucTiS01p-d6z@nathan>
	<[email protected]>
	<aBkQLSkx1zUJ-LwJ@nathan>
	<aBtzZ4PyccUVCcyA@nathan>
	<CAMT0RQTXiqH7zdQEVSVd2L7_Cw4wQ1eHOD8hfZ+0vecMXJWc-w@mail.gmail.com>
	<aG2ISJC__3lQwRqY@nathan>
	<CAMT0RQStPtHfKwowd88Q0tynX0x=uJSKn=ihP8syhDJ6cH3DHQ@mail.gmail.com>
	<aG6srPib60NzJBeg@nathan>
	<CAMT0RQRT3KkwoQkx=YBdd_o9SqXxOt16fqQsscH_n+40Z57N7w@mail.gmail.com>
	<CAH5HC942o6j1qyVysiBtO+Vpb=XOBPbf3rKqsOLtpDpp0SzjkA@mail.gmail.com>

On Thu, Jul 10, 2025 at 06:05:26PM +0530, Nitin Motiani wrote:
> -		 * pg_largeobject_metadata, after the dump is restored.
> +		 * pg_largeobject_metadata, after the dump is restored.  In versions
> +		 * before v12, this is done via proper large object commands.  In
> +		 * newer versions, we dump the content of pg_largeobject_metadata and
> +		 * any associated pg_shdepend rows, which is faster to restore.
>  		 */
> 
> Should the comment provide further detail on why this is only being done
> for v12 and above?

Yes.  I've fixed this in v3.

-- 
nathan


view thread (46+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
  In-Reply-To: <aHAzv9pgJh2Wa3M1@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox