pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: daniel@yesql.se <daniel@yesql.se>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Thu, 01 Jul 2021 15:10:05 -0400
Message-ID: <748144.1625166605@sss.pgh.pa.us> (raw)
In-Reply-To: <a6c5b570-a7b7-bd0b-59e7-33af54f51dbe@enterprisedb.com>
References: <3128896.1624742969@sss.pgh.pa.us>
	<18eda75d-af6d-3fc0-03b6-607eff9f392a@enterprisedb.com>
	<622907.1625084114@sss.pgh.pa.us>
	<630837.1625092151@sss.pgh.pa.us>
	<67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com>
	<9d35a4ac-2c75-cb44-95ab-61d69deb072e@enterprisedb.com>
	<745046.1625163264@sss.pgh.pa.us>
	<a6c5b570-a7b7-bd0b-59e7-33af54f51dbe@enterprisedb.com>

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 01.07.21 20:14, Tom Lane wrote:
>> The problem then is, what happens when the extra action fails?
>> Without .DELETE_ON_ERROR, the shlib is still there and the next
>> make run will think everything's good.

> Right.  .DELETE_ON_ERROR is already set in Makefile.global, so it's not 
> necessary to set it again.

Right.  Since we use that, we don't actually have that problem.
What we'd have instead is that debugging an unexpected failure
of the "extra action" would be painful, because there would be
no way short of modifying the Makefiles to create its input data.
So I think the other solution with a separate rule is better.

			regards, tom lane





view thread (57+ messages)  latest in thread

Message-ID: <748144.1625166605@sss.pgh.pa.us>
Permalink:  ../748144.1625166605@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/748144.1625166605@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pchampion@vmware.com, daniel@yesql.se, michael@paquier.xyz
  Subject: Re: Preventing abort() and exit() calls in libpq
  In-Reply-To: <748144.1625166605@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox