From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Dave Page <dpage@postgresql.org>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pl/perl extension fails on Windows
Date: Wed, 29 Nov 2017 23:34:56 -0500
Message-ID: <84899.1512016496@sss.pgh.pa.us> (raw)
In-Reply-To: <20171130041441.GA3161526@rfd.leadboat.com>
References: <12588.1502375771@sss.pgh.pa.us>
<14838.1502379286@sss.pgh.pa.us>
<1708!2.1502718166@sss.pgh.pa.us>
<10406.1502743029@sss.pgh.pa.us>
<CA+OCxow_P_K9kpsSeMwdnqoiaAx3YEDN6P1s-93L5A_iTUYHuw@mail.gmail.com>
<1914.1502978317@sss.pgh.pa.us>
<CA+OCxow3A8waWr3drvFtmBwfgD8RF6w7rC2z9eY8eMJ7zz3y4w@mail.gmail.com>
<4515.1502981857@sss.pgh.pa.us>
<17646.1502983856@sss.pgh.pa.us>
<19438.1502986558@sss.pgh.pa.us>
<20171130041441.GA3161526@rfd.leadboat.com>
Noah Misch <noah@leadboat.com> writes:
> On Thu, Aug 17, 2017 at 12:15:58PM -0400, Tom Lane wrote:
>> ... it's now looking to me like we should do the above with X = 5.13.4.
>> That won't be a perfect solution, but it's about the best we can
>> readily do. Realistically, nobody out in the wider world is likely
>> to care about building current PG releases against such old Perl
>> versions on Windows; if we satisfy our older buildfarm critters,
>> it's enough for me.
> MinGW default behavior matches "cl -D_USE_32BIT_TIME_T", and MSVC >= 2005
> default behavior matches "gcc -D__MINGW_USE_VC2005_COMPAT"[1]. MinGW-built
> Perl[2] does not mention _USE_32BIT_TIME_T in $Config{ccflags}, so we
> typically must add _USE_32BIT_TIME_T when using MSVC to build 32-bit against
> MinGW-built Perl. I'm considering two ways to achieve this:
I don't really have an opinion about the relative merits of these changes,
but why do anything? The existing solution has the buildfarm happy, and
we've not heard any field complaints that I saw. I'm not sure we should
spend more time on supporting obsolete toolchain combinations that aren't
represented in the buildfarm.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, dpage@postgresql.org, sandeep.thakkar@enterprisedb.com, ashu.coek88@gmail.com, robertmhaas@gmail.com
Subject: Re: pl/perl extension fails on Windows
In-Reply-To: <84899.1512016496@sss.pgh.pa.us>
References: <12588.1502375771@sss.pgh.pa.us> <14838.1502379286@sss.pgh.pa.us> <1708!2.1502718166@sss.pgh.pa.us> <10406.1502743029@sss.pgh.pa.us> <CA+OCxow_P_K9kpsSeMwdnqoiaAx3YEDN6P1s-93L5A_iTUYHuw@mail.gmail.com> <1914.1502978317@sss.pgh.pa.us> <CA+OCxow3A8waWr3drvFtmBwfgD8RF6w7rC2z9eY8eMJ7zz3y4w@mail.gmail.com> <4515.1502981857@sss.pgh.pa.us> <17646.1502983856@sss.pgh.pa.us> <19438.1502986558@sss.pgh.pa.us> <20171130041441.GA3161526@rfd.leadboat.com> <84899.1512016496@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox