pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedAdd a description to the documentation that toast_tuple_target affects "Main"
5+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2020-10-15 564a410c81 53c07dbbf3 72b1574090 cc1fc7b862 doc: Mention that toast_tuple_target affects also column marked as Main.
* Add a description to the documentation that toast_tuple_target affects "Main"
@ 2020-10-09 08:43 Shinya Okano <btokanosn@oss.nttdata.com>
2020-10-13 01:40 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Shinya Okano @ 2020-10-09 08:43 UTC (permalink / raw)
To: pgsql-hackers
Hi,
Regarding the toast_tuple_target parameter of CREATE TABLE, the
documentation says that it only affects External or Extended, but it
actually affects the compression of Main as well.
The attached patch modifies the document to match the actual behavior.
Regards,
--
Shinya Okano
Attachments:
Add-Main-to-the-toast_tuple_target-doc.patch (text/x-diff, 1.3K) download
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
index 28f844071b..76d80fb567 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -1359,10 +1359,11 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
<listitem>
<para>
The toast_tuple_target specifies the minimum tuple length required before
- we try to move long column values into TOAST tables, and is also the
- target length we try to reduce the length below once toasting begins.
- This only affects columns marked as either External or Extended
- and applies only to new tuples; there is no effect on existing rows.
+ we try to compress long column values or to move into TOAST tables, and
+ is also the target length we try to reduce the length below once toasting
+ begins. This affects columns marked as External (for move),
+ Main (for compression), or Extended (for both) and applies only to new
+ tuples. There is no effect on existing rows.
By default this parameter is set to allow at least 4 tuples per block,
which with the default block size will be 2040 bytes. Valid values are
between 128 bytes and the (block size - header), by default 8160 bytes.
* Re: Add a description to the documentation that toast_tuple_target affects "Main"
2020-10-09 08:43 Add a description to the documentation that toast_tuple_target affects "Main" Shinya Okano <btokanosn@oss.nttdata.com>
@ 2020-10-13 01:40 ` Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
2020-10-13 16:30 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 5+ messages in thread
From: Kasahara Tatsuhito @ 2020-10-13 01:40 UTC (permalink / raw)
To: Shinya Okano <btokanosn@oss.nttdata.com>; +Cc: pgsql-hackers
Hi,
On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>
> Hi,
>
> Regarding the toast_tuple_target parameter of CREATE TABLE, the
> documentation says that it only affects External or Extended, but it
> actually affects the compression of Main as well.
>
> The attached patch modifies the document to match the actual behavior.
+1
Best regards,
--
Tatsuhito Kasahara
kasahara.tatsuhito _at_ gmail.com
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Add a description to the documentation that toast_tuple_target affects "Main"
2020-10-09 08:43 Add a description to the documentation that toast_tuple_target affects "Main" Shinya Okano <btokanosn@oss.nttdata.com>
2020-10-13 01:40 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
@ 2020-10-13 16:30 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2020-10-14 07:21 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Shinya Okano <btokanosn@oss.nttdata.com>
0 siblings, 1 reply; 5+ messages in thread
From: Fujii Masao @ 2020-10-13 16:30 UTC (permalink / raw)
To: Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>; Shinya Okano <btokanosn@oss.nttdata.com>; +Cc: pgsql-hackers
On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
> Hi,
>
> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>>
>> Hi,
>>
>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>> documentation says that it only affects External or Extended, but it
>> actually affects the compression of Main as well.
>>
>> The attached patch modifies the document to match the actual behavior.
> +1
+1
+ we try to compress long column values or to move into TOAST tables, and
"we try to compress and/or move long column values into TOAST tables, and" is better?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Add a description to the documentation that toast_tuple_target affects "Main"
2020-10-09 08:43 Add a description to the documentation that toast_tuple_target affects "Main" Shinya Okano <btokanosn@oss.nttdata.com>
2020-10-13 01:40 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
2020-10-13 16:30 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Fujii Masao <masao.fujii@oss.nttdata.com>
@ 2020-10-14 07:21 ` Shinya Okano <btokanosn@oss.nttdata.com>
2020-10-15 02:12 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 5+ messages in thread
From: Shinya Okano @ 2020-10-14 07:21 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@oss.nttdata.com>; Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>; +Cc: pgsql-hackers
On 2020-10-14 01:30, Fujii Masao wrote:
> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano
>> <btokanosn@oss.nttdata.com> wrote:
>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>> documentation says that it only affects External or Extended, but it
>>> actually affects the compression of Main as well.
>>>
>>> The attached patch modifies the document to match the actual
>>> behavior.
>> +1
>
> +1
>
> + we try to compress long column values or to move into TOAST
> tables, and
>
> "we try to compress and/or move long column values into TOAST tables,
> and" is better?
Thank you everyone for reviews.
I attached the new version of the patch.
Regards,
--
Shinya Okano
Attachments:
V2-Add-Main-to-the-toast_tuple_target-doc.patch (text/x-diff, 1.3K) download
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
index 28f844071b..fd6777ae01 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -1359,10 +1359,11 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
<listitem>
<para>
The toast_tuple_target specifies the minimum tuple length required before
- we try to move long column values into TOAST tables, and is also the
- target length we try to reduce the length below once toasting begins.
- This only affects columns marked as either External or Extended
- and applies only to new tuples; there is no effect on existing rows.
+ we try to compress and/or move long column values into TOAST tables, and
+ is also the target length we try to reduce the length below once toasting
+ begins. This affects columns marked as External (for move),
+ Main (for compression), or Extended (for both) and applies only to new
+ tuples. There is no effect on existing rows.
By default this parameter is set to allow at least 4 tuples per block,
which with the default block size will be 2040 bytes. Valid values are
between 128 bytes and the (block size - header), by default 8160 bytes.
* Re: Add a description to the documentation that toast_tuple_target affects "Main"
2020-10-09 08:43 Add a description to the documentation that toast_tuple_target affects "Main" Shinya Okano <btokanosn@oss.nttdata.com>
2020-10-13 01:40 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
2020-10-13 16:30 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Fujii Masao <masao.fujii@oss.nttdata.com>
2020-10-14 07:21 ` Re: Add a description to the documentation that toast_tuple_target affects "Main" Shinya Okano <btokanosn@oss.nttdata.com>
@ 2020-10-15 02:12 ` Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2020-10-15 02:12 UTC (permalink / raw)
To: Shinya Okano <btokanosn@oss.nttdata.com>; Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>; +Cc: pgsql-hackers
On 2020/10/14 16:21, Shinya Okano wrote:
> On 2020-10-14 01:30, Fujii Masao wrote:
>> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>>> documentation says that it only affects External or Extended, but it
>>>> actually affects the compression of Main as well.
>>>>
>>>> The attached patch modifies the document to match the actual behavior.
>>> +1
>>
>> +1
>>
>> + we try to compress long column values or to move into TOAST tables, and
>>
>> "we try to compress and/or move long column values into TOAST tables,
>> and" is better?
>
> Thank you everyone for reviews.
> I attached the new version of the patch.
Thanks for updating the patch! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2020-10-15 02:12 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 08:43 Add a description to the documentation that toast_tuple_target affects "Main" Shinya Okano <btokanosn@oss.nttdata.com>
2020-10-13 01:40 ` Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
2020-10-13 16:30 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2020-10-14 07:21 ` Shinya Okano <btokanosn@oss.nttdata.com>
2020-10-15 02:12 ` Fujii Masao <masao.fujii@oss.nttdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox