pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFeature improvement of tab completion for DEALLOCATE
4+ messages / 2 participants
[nested] [flat]
* Feature improvement of tab completion for DEALLOCATE
@ 2020-09-25 04:45 btnakamichin <btnakamichin@oss.nttdata.com>
2020-09-25 05:30 ` Re: Feature improvement of tab completion for DEALLOCATE Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 4+ messages in thread
From: btnakamichin @ 2020-09-25 04:45 UTC (permalink / raw)
To: pgsql-hackers
Hello!
I’d like to improve the deallocate tab completion.
The deallocate tab completion can’t complement “ALL”. Therefore, this
patch fixes the problem.
Regards,
Naoki Nakamichi
Attachments:
[text/x-diff] fix_tab_complete_deallocate.patch (511B, ../../ec1a45b06edfce13706f2c765778d8c2@oss.nttdata.com/2-fix_tab_complete_deallocate.patch)
download | inline diff:
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 9c6f5ecb6a..d877cc86f0 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -2911,7 +2911,7 @@ psql_completion(const char *text, int start, int end)
/* DEALLOCATE */
else if (Matches("DEALLOCATE"))
- COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
+ COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements " UNION SELECT 'ALL'");
/* DECLARE */
else if (Matches("DECLARE", MatchAny))
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Feature improvement of tab completion for DEALLOCATE
2020-09-25 04:45 Feature improvement of tab completion for DEALLOCATE btnakamichin <btnakamichin@oss.nttdata.com>
@ 2020-09-25 05:30 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2020-09-25 06:18 ` Re: Feature improvement of tab completion for DEALLOCATE btnakamichin <btnakamichin@oss.nttdata.com>
0 siblings, 1 reply; 4+ messages in thread
From: Fujii Masao @ 2020-09-25 05:30 UTC (permalink / raw)
To: btnakamichin <btnakamichin@oss.nttdata.com>; pgsql-hackers
On 2020/09/25 13:45, btnakamichin wrote:
> Hello!
>
> I’d like to improve the deallocate tab completion.
>
> The deallocate tab completion can’t complement “ALL”. Therefore, this patch fixes the problem.
Thanks for the patch! It looks basically good, but I think it's better
to add newline just before UNION to avoid long line, as follows.
- COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
+ COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
+ " UNION SELECT 'ALL'");
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Feature improvement of tab completion for DEALLOCATE
2020-09-25 04:45 Feature improvement of tab completion for DEALLOCATE btnakamichin <btnakamichin@oss.nttdata.com>
2020-09-25 05:30 ` Re: Feature improvement of tab completion for DEALLOCATE Fujii Masao <masao.fujii@oss.nttdata.com>
@ 2020-09-25 06:18 ` btnakamichin <btnakamichin@oss.nttdata.com>
2020-09-28 02:31 ` Re: Feature improvement of tab completion for DEALLOCATE Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 4+ messages in thread
From: btnakamichin @ 2020-09-25 06:18 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@oss.nttdata.com>; +Cc: pgsql-hackers
2020-09-25 14:30 に Fujii Masao さんは書きました:
> On 2020/09/25 13:45, btnakamichin wrote:
>> Hello!
>>
>> I’d like to improve the deallocate tab completion.
>>
>> The deallocate tab completion can’t complement “ALL”. Therefore, this
>> patch fixes the problem.
>
> Thanks for the patch! It looks basically good, but I think it's better
> to add newline just before UNION to avoid long line, as follows.
>
> -
> COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
> +
> COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
> + " UNION SELECT
> 'ALL'");
>
> Regards,
Thank you, I appreciate your comment.
I have attached pattch with newline.
Regards,
NaokiNskamichi
Attachments:
[text/x-diff] fix_tab_complete_deallocate_v2.patch (557B, ../../680a8129485eb754f31ad0ccc1f7151f@oss.nttdata.com/2-fix_tab_complete_deallocate_v2.patch)
download | inline diff:
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index d877cc86f0..75f81d66dc 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -2911,7 +2911,8 @@ psql_completion(const char *text, int start, int end)
/* DEALLOCATE */
else if (Matches("DEALLOCATE"))
- COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements " UNION SELECT 'ALL'");
+ COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
+ " UNION SELECT 'ALL'");
/* DECLARE */
else if (Matches("DECLARE", MatchAny))
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Feature improvement of tab completion for DEALLOCATE
2020-09-25 04:45 Feature improvement of tab completion for DEALLOCATE btnakamichin <btnakamichin@oss.nttdata.com>
2020-09-25 05:30 ` Re: Feature improvement of tab completion for DEALLOCATE Fujii Masao <masao.fujii@oss.nttdata.com>
2020-09-25 06:18 ` Re: Feature improvement of tab completion for DEALLOCATE btnakamichin <btnakamichin@oss.nttdata.com>
@ 2020-09-28 02:31 ` Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 0 replies; 4+ messages in thread
From: Fujii Masao @ 2020-09-28 02:31 UTC (permalink / raw)
To: btnakamichin <btnakamichin@oss.nttdata.com>; +Cc: pgsql-hackers
On 2020/09/25 15:18, btnakamichin wrote:
> 2020-09-25 14:30 に Fujii Masao さんは書きました:
>> On 2020/09/25 13:45, btnakamichin wrote:
>>> Hello!
>>>
>>> I’d like to improve the deallocate tab completion.
>>>
>>> The deallocate tab completion can’t complement “ALL”. Therefore, this patch fixes the problem.
>>
>> Thanks for the patch! It looks basically good, but I think it's better
>> to add newline just before UNION to avoid long line, as follows.
>>
>> - COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
>> + COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
>> + " UNION SELECT 'ALL'");
>>
>> Regards,
>
> Thank you, I appreciate your comment.
>
> I have attached pattch with newline.
Thanks for updating the patch! But it contains only the diff from the previous patch.
Anyway, I pushed the change that you proposed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2020-09-28 02:31 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 04:45 Feature improvement of tab completion for DEALLOCATE btnakamichin <btnakamichin@oss.nttdata.com>
2020-09-25 05:30 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2020-09-25 06:18 ` btnakamichin <btnakamichin@oss.nttdata.com>
2020-09-28 02:31 ` Fujii Masao <masao.fujii@oss.nttdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox