public inbox for [email protected]  

help / color / mirror / Atom feed

Re: Minor refactor of the code in ExecScanExtended()
2+ messages / 2 participants
[nested] [flat]

* Re: Minor refactor of the code in ExecScanExtended()
@ 2026-01-19 04:50 Aditya Gollamudi <[email protected]>
  2026-03-25 01:53 ` Re: Minor refactor of the code in ExecScanExtended() Henson Choi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Gollamudi @ 2026-01-19 04:50 UTC (permalink / raw)
  To: cca5507 <[email protected]>; +Cc: pgsql-hackers <[email protected]>

On Sun, Jan 18, 2026 at 7:31 PM cca5507 <[email protected]> wrote:

> Hi,
>
> The current code:
>
> if (!qual && !projInfo)
> {
> ResetExprContext(econtext);
> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
> }
>
> ResetExprContext(econtext);
>
> The following format might be simpler:
>
> ResetExprContext(econtext);
>
> if (!qual && !projInfo)
> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
>
> Attach a patch to do this.
>
> --
> Regards,
> ChangAo Chen
>
> Hi,

+1, seems like a simple refactor.
Tests are passing locally for me!

- Adi Gollamudi


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Minor refactor of the code in ExecScanExtended()
  2026-01-19 04:50 Re: Minor refactor of the code in ExecScanExtended() Aditya Gollamudi <[email protected]>
@ 2026-03-25 01:53 ` Henson Choi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Henson Choi @ 2026-03-25 01:53 UTC (permalink / raw)
  To: Aditya Gollamudi <[email protected]>; cca5507 <[email protected]>; +Cc: pgsql-hackers <[email protected]>

Hi hackers,

2026년 1월 19일 (월) PM 1:51, Aditya Gollamudi <[email protected]>님이 작성:

> On Sun, Jan 18, 2026 at 7:31 PM cca5507 <[email protected]> wrote:
>
>> Hi,
>>
>> The current code:
>>
>> if (!qual && !projInfo)
>> {
>> ResetExprContext(econtext);
>> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
>> }
>>
>> ResetExprContext(econtext);
>>
>> The following format might be simpler:
>>
>> ResetExprContext(econtext);
>>
>> if (!qual && !projInfo)
>> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
>>
>> Attach a patch to do this.
>>
>> --
>> Regards,
>> ChangAo Chen
>>
>> Hi,
>
> +1, seems like a simple refactor.
> Tests are passing locally for me!
>
> - Adi Gollamudi
>

+1, agreed.

The refactored version is cleaner and easier to read by moving
ResetExprContext() before the early return,
eliminating the duplicated logic.

Best regards,
Henson


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2026-03-25 01:53 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-19 04:50 Re: Minor refactor of the code in ExecScanExtended() Aditya Gollamudi <[email protected]>
2026-03-25 01:53 ` Henson Choi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox