From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description
Date: Wed, 25 May 2022 13:04:04 +0900
Message-ID: <Yo2qtFNyJUe1rgF5@paquier.xyz> (raw)
In-Reply-To: <20220523164142.GB938919@nathanxps13>
References: <CAB8KJ=jhPyYFu-A5r-ZGP+Ax715mUKsMxAGcEQ9Cx_mBAmrPow@mail.gmail.com>
<20220520230837.GB877934@nathanxps13>
<YohcelRv74nuHC9Z@paquier.xyz>
<20220521185743.GA886636@nathanxps13>
<YomLAynQiordq3lg@paquier.xyz>
<20220522202608.GA892371@nathanxps13>
<YorM9Kv4bFVBoCsI@paquier.xyz>
<20220523164142.GB938919@nathanxps13>
On Mon, May 23, 2022 at 09:41:42AM -0700, Nathan Bossart wrote:
> I think we need to be careful about saying "member of" when we really mean
> "roles with privileges of." Unless I am mistaken, role membership alone is
> not sufficient for viewing this information. You also need to inherit the
> role's privileges via INHERIT.
Good point. So this would give, to be exact:
"This information is only visible to superusers, roles with privileges
of the pg_read_all_stats role, and and the user owning the sessionS
being reported on (including sessions belonging to a role they have
the privileges of)."
Opinions?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, nathandbossart@gmail.com, barwick@gmail.com
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description
In-Reply-To: <Yo2qtFNyJUe1rgF5@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox