From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Logging query parmeters in auto_explain
Date: Wed, 29 Jun 2022 09:17:49 +0900
Message-ID: <YruaLdkyEgu6L5ML@paquier.xyz> (raw)
In-Reply-To: <87a69xkv7x.fsf@wibble.ilmari.org>
References: <87ee09mohb.fsf@wibble.ilmari.org>
<Yp8D4kb2qZnhNAWJ@paquier.xyz>
<8735ggn2lf.fsf@wibble.ilmari.org>
<YqFQbYkFLF4fXuZX@paquier.xyz>
<87tu8tla5s.fsf@wibble.ilmari.org>
<Yqg9tlxk0Ghwd7Of@paquier.xyz>
<87iloml5a5.fsf@wibble.ilmari.org>
<87fsjql51e.fsf@wibble.ilmari.org>
<YrqzsLM96tEbFxeU@paquier.xyz>
<87a69xkv7x.fsf@wibble.ilmari.org>
On Tue, Jun 28, 2022 at 10:12:18AM +0100, Dagfinn Ilmari Mannsåker wrote:
> That makes sense, but I still think the query_log() function definition
> should go at the end (after done_testing()), so the machinery doesn't
> distract from what's actually being tested.
The majority of TAP scripts have their subroutines at the beginning of
the script, and there are few having that at the end. I won't fight
you on that, but the former is more consistent.
> Also, the second paragraph of the second commit message now belongs in
> the first commit (without the word "Also").
Yep, will fix. I usually rewrite commit messages before merging them.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, ilmari@ilmari.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Logging query parmeters in auto_explain
In-Reply-To: <YruaLdkyEgu6L5ML@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox