From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: gkokolatos@pm.me, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Date: Thu, 13 Apr 2023 09:37:06 +0900
Message-ID: <ZDdOstf12KHSarmS@paquier.xyz> (raw)
In-Reply-To: <ZDc2OBeMYbhmDEYl@telsasoft.com>
References: <qRJGr1JjK3B_pbOxyGqI0iGJWEcRxnq9c7_mIqTY1CIIvYMY0hamPIrvjuS-6gyjr_ItOG8SLRacF1oj7d8R4QKHfZp85YTHI9B-U6LSLAQ=@pm.me>
<qSzzmYsXqUf1gDvFspOEbqoE8U_F8IsphDG8c25VZ5KTXimQVYfLvnCcuU7_X2raa2SzZinDF0NpDIKSOALRUYP8pu_NL5QJwIDdR_RT-4U=@pm.me>
<8ffd14fe-0278-7f8d-78d4-472816d06268@enterprisedb.com>
<ZDX+J72FYmJhH+fC@telsasoft.com>
<ZDYEPDbFAua+4hlr@paquier.xyz>
<ZDYHP4SvY2eejTj/@telsasoft.com>
<ZDcvdPVVi22mXPfR@paquier.xyz>
<ZDc2OBeMYbhmDEYl@telsasoft.com>
On Wed, Apr 12, 2023 at 05:52:40PM -0500, Justin Pryzby wrote:
> I don't think you need to call parse_compress_specification(NONE).
> As you wrote it, if zlib is unavailable, there's no parse(NONE) call,
> even for directory and custom formats. And there's no parse(NONE) call
> for plan format when zlib is available.
Yeah, that's not necessary, but I was wondering if it made the code a
bit cleaner, or else the non-zlib path would rely on the default
compression method string.
> The old way had preprocessor #if around both the "if" and "else" - is
> that what you meant?
>
> If you don't insist on calling parse(NONE), the only change is to remove
> the empty #else, which was my original patch.
Removing the empty else has as problem to create an empty if block,
which could be itself a cause of warnings?
> If I were to rewrite the comment, it'd say:
>
> + * When gzip is available, custom and directory formats are compressed by
> + * default
Okay.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ZDdOstf12KHSarmS@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, pryzby@telsasoft.com, tomas.vondra@enterprisedb.com, rachelmheaton@gmail.com
Subject: Re: Add LZ4 compression in pg_dump
In-Reply-To: <ZDdOstf12KHSarmS@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox