pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: gkokolatos@pm.me, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Date: Wed, 12 Apr 2023 19:53:53 -0500
Message-ID: <ZDdSoaE/30dS+Fxr@telsasoft.com> (raw)
In-Reply-To: <ZDdOstf12KHSarmS@paquier.xyz>
References: <qRJGr1JjK3B_pbOxyGqI0iGJWEcRxnq9c7_mIqTY1CIIvYMY0hamPIrvjuS-6gyjr_ItOG8SLRacF1oj7d8R4QKHfZp85YTHI9B-U6LSLAQ=@pm.me>
	<qSzzmYsXqUf1gDvFspOEbqoE8U_F8IsphDG8c25VZ5KTXimQVYfLvnCcuU7_X2raa2SzZinDF0NpDIKSOALRUYP8pu_NL5QJwIDdR_RT-4U=@pm.me>
	<8ffd14fe-0278-7f8d-78d4-472816d06268@enterprisedb.com>
	<ZDX+J72FYmJhH+fC@telsasoft.com>
	<ZDYEPDbFAua+4hlr@paquier.xyz>
	<ZDYHP4SvY2eejTj/@telsasoft.com>
	<ZDcvdPVVi22mXPfR@paquier.xyz>
	<ZDc2OBeMYbhmDEYl@telsasoft.com>
	<ZDdOstf12KHSarmS@paquier.xyz>

On Thu, Apr 13, 2023 at 09:37:06AM +0900, Michael Paquier wrote:
> > If you don't insist on calling parse(NONE), the only change is to remove
> > the empty #else, which was my original patch.
> 
> Removing the empty else has as problem to create an empty if block,
> which could be itself a cause of warnings?

I doubt it - in the !HAVE_LIBZ case, it's currently an "if" statement
with nothing but a comment, which isn't a problem.

I think the only issue with an empty "if" is when you have no braces,
like:

	if (...)
#if ...
		something;
#endif

	// problem here //

-- 
Justin





view thread (205+ messages)  latest in thread

Message-ID: <ZDdSoaE/30dS+Fxr@telsasoft.com>
Permalink:  ../ZDdSoaE%2F30dS+Fxr@telsasoft.com/
Also on:    postgresql.org/message-id/ZDdSoaE/30dS+Fxr@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, michael@paquier.xyz, tomas.vondra@enterprisedb.com, rachelmheaton@gmail.com
  Subject: Re: Add LZ4 compression in pg_dump
  In-Reply-To: <ZDdSoaE/30dS+Fxr@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox