From: Bruce Momjian <bruce@momjian.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: tgl@sss.pgh.pa.us
Cc: daniel@yesql.se
Cc: pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
Date: Tue, 15 Oct 2024 17:51:02 -0400
Message-ID: <Zw7jxpHuWYENZ71z@momjian.us> (raw)
In-Reply-To: <a4deecf3-d912-438e-ba61-18bd629c42bb@eisentraut.org>
References: <20241011114122.c90f8a871462da36f2e2afeb@sraoss.co.jp>
<20241011.121650.2077607600187658573.ishii@postgresql.org>
<20241011123653.09a67d3ad7b60a59e4558403@sraoss.co.jp>
<Zw1rf7vm3FqpItw4@momjian.us>
<Zw1_j_jofafQbNKl@momjian.us>
<20241015101036.d8c29e4aada1c3e92ddcef9d@sraoss.co.jp>
<Zw6eQxtpXIccYpOQ@momjian.us>
<f1bc1bcd-a71c-411a-9bfd-8cd6ec2ae007@eisentraut.org>
<Zw7ScRYKZVj3pBva@momjian.us>
<a4deecf3-d912-438e-ba61-18bd629c42bb@eisentraut.org>
On Tue, Oct 15, 2024 at 11:08:15PM +0200, Peter Eisentraut wrote:
> On 15.10.24 22:37, Bruce Momjian wrote:
> > > I don't understand the point of this. Maybe it's okay to try to detect
> > > certain "hidden" whitespace characters, like in the case that started this
> > > thread. But I don't see the value in prohibiting all non-ASCII characters,
> > > as is being proposed here.
> > Well, we can only use Latin-1, so the idea is that we will be explicit
> > about specifying Latin-1 only as HTML entities, rather than letting
> > non-Latin-1 creep in as UTF8.
>
> But your patch prohibits even otherwise allowed Latin-1 characters.
Well, yes, they are Latin-1 characters encoded as UTF-8.
> I don't see why we need to enforce this at this level. Whatever downstream
> toolchain has requirements about which characters are allowed will complain
> if it encounters a character it doesn't like.
Uh, the PDF build does not complain if you pass it a non-Latin-1 UTF8
characters. To test this I added some Russian characters (non-Latin-1)
to release.sgml:
(⟨б⟩, ⟨в⟩, ⟨г⟩, ⟨д⟩, ⟨ж⟩, ⟨з⟩, ⟨к⟩, ⟨л⟩, ⟨м⟩, ⟨н⟩, ⟨п⟩, ⟨р⟩, ⟨с⟩, ⟨т⟩,
⟨ф⟩, ⟨х⟩, ⟨ц⟩, ⟨ч⟩, ⟨ш⟩, ⟨щ⟩), ten vowels (⟨а⟩, ⟨е⟩, ⟨ё⟩, ⟨и⟩, ⟨о⟩, ⟨у⟩,
⟨ы⟩, ⟨э⟩, ⟨ю⟩, ⟨я⟩), a semivowel / consonant (⟨й⟩), and two modifier
letters or "signs" (⟨ъ⟩, ⟨ь⟩)
and I ran 'make postgres-US.pdf', and then removed the Russian
characters and ran the same command again. The output, including stderr
was identical. The PDFs, of course, were not, with the Russian
characters showing as "####". Makefile output attached.
So, in summary, the PDF build is allowed to complain, but it does not.
Even if it did complain, odds are most people are only going to test an
HTML build of their patch, if at all, rather than a PDF build.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
Attachments:
us.out (text/plain, 130.8K) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, peter@eisentraut.org, nagata@sraoss.co.jp, ishii@postgresql.org, tgl@sss.pgh.pa.us, daniel@yesql.se
Subject: Re: Doc: typo in config.sgml
In-Reply-To: <Zw7jxpHuWYENZ71z@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox