From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nisha Moond <nisha.moond412@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Date: Wed, 28 May 2025 11:43:52 +0900
Message-ID: <aDZ4aBbJ_vZTMKac@paquier.xyz> (raw)
In-Reply-To: <aDYabIxCPxu4GZxT@nathan>
References: <aA_4S5ZBaI_Qje2s@nathan>
<910625.1745878759@sss.pgh.pa.us>
<aBEO7vzq1jw9L_Pv@nathan>
<1055453.1745949714@sss.pgh.pa.us>
<aBF1ii89jdzQsVvB@paquier.xyz>
<aBo7zUx3XpbA2Jo1@nathan>
<aBqUlxmOf9qvVIhT@paquier.xyz>
<aBu6xdbOqelnZOCZ@nathan>
<aBvy3BQL_vaJhnio@paquier.xyz>
<aDYabIxCPxu4GZxT@nathan>
On Tue, May 27, 2025 at 03:02:52PM -0500, Nathan Bossart wrote:
> Here is what I have staged for commit for the others. I'm hoping to push
> these in the next couple of days.
Thanks for the refreshed versions. Looks sensible to me overall.
+static inline void
+AssertHasSnapshotForToast(Relation rel)
[...]
+ /*
+ * Commit 16bf24e fixed accesses to pg_replication_origin without a
+ * an active snapshot by removing its TOAST table. On older branches,
+ * these bugs are left in place. Its only varlena column is roname (the
+ * replication origin name), so this is only a problem if the name
+ * requires out-of-line storage, which seems unlikely. In any case,
+ * fixing it doesn't seem worth extra code churn on the back-branches.
+ */
+ if (RelationGetRelid(rel) == ReplicationOriginRelationId)
+ return;
As of the back-branches but not HEAD, this shortcut makes sense.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, nathandbossart@gmail.com, tgl@sss.pgh.pa.us, nisha.moond412@gmail.com, euler@eulerto.com, amit.kapila16@gmail.com, exclusion@gmail.com, jkatz@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
In-Reply-To: <aDZ4aBbJ_vZTMKac@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox