public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: shihao zhong <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
Date: Thu, 26 Mar 2026 11:07:52 -0500
Message-ID: <acVZ2O0938nWa73w@nathan> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<aFwT31Rw-Oj-bgO9@nathan>
<[email protected]>
<rzxpxod4c4la62yvutyrvgoyilrl2fx55djaf2suidy7np5m6c@3l2ln476eadh>
<ab2iXwhRe3fFNPfp@nathan>
<aglpy2jbnb75vufdx6hqkgokquzmoshcbnuxlcxhum4k7tyi7m@27m4hbxo2u2g>
<acMGcoUwA9CiPPU1@nathan>
<loig4i4hc4vuybn6uv6e2kgqm37sebbzujkrvdf6uhbxq5dsfm@7wbkmucts3eu>
<acQAXPXov4cbyUx0@nathan>
<[email protected]>
On Thu, Mar 26, 2026 at 11:22:25AM +0900, Michael Paquier wrote:
> Once vacuum_rel() has its VacuumParams changed to a pointer, renaming
> it to params_local and use params_local in all its code paths looks
> sensible. On top of what you are doing, I would add a big warning
> comment at the top of the routine to mention that "params" should not
> be used directly in the routine. The local copies should be used.
Wait... Can't we just pass params by value only to vacuum_rel()? Doesn't
this accomplish what we need?
--
nathan
view thread (32+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
In-Reply-To: <acVZ2O0938nWa73w@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox