From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Robert Treat <rob@xzilla.net>
Cc: satyanarlapuram@gmail.com, pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: tndrwang@gmail.com
Subject: Re: Add pg_stat_autovacuum_priority
Date: Thu, 9 Apr 2026 10:23:59 -0500
Message-ID: <adfEj8Bn4IWbi_wp@nathan> (raw)
In-Reply-To: <adbGfTMw8BiHDMnM@nathan>
References: <adFiCgN22xJ7Z-oR@nathan>
<CAA5RZ0vRP-W2wJD2OxEb-=VGj2sp5pMCqHQg9YJiuDVPhaY5jQ@mail.gmail.com>
<adQsdvPPNviWMCXb@nathan>
<5684f479-858e-4c5d-b8f5-bcf05de1f909@gmail.com>
<3077290.1775668665@sss.pgh.pa.us>
<adaWuTR7oCKodH7k@nathan>
<3097984.1775674400@sss.pgh.pa.us>
<adan_E0o69p81lIj@nathan>
<3101163.1775676098@sss.pgh.pa.us>
<adbGfTMw8BiHDMnM@nathan>
On Wed, Apr 08, 2026 at 04:19:57PM -0500, Nathan Bossart wrote:
> On Wed, Apr 08, 2026 at 03:21:38PM -0400, Tom Lane wrote:
>> Nathan Bossart <nathandbossart@gmail.com> writes:
>>> FWIW that elog() shouldn't be emitting anything from the view, unless
>>> something is broken.
>>
>> [ looks again... ] Oh, you mean because pg_stat_get_autovacuum_scores
>> passes 0 for elevel instead of any of the valid elevel constants.
>> Can you say "undocumented cowboy hack"? I'd be happier if we added
>> something like "#define LOG_NEVER 0 /* Never emit this message */"
>> to elog.h and used that.
>
> Yeah... I should've done that originally. Here's a patch that I'll apply
> in the next day or so, barring objections.
Committed. Working on Sami's patch next.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, exclusion@gmail.com, samimseih@gmail.com, bharath.rupireddyforpostgres@gmail.com, rob@xzilla.net, tndrwang@gmail.com
Subject: Re: Add pg_stat_autovacuum_priority
In-Reply-To: <adfEj8Bn4IWbi_wp@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox