pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade: Error out on too many command-line arguments
Date: Fri, 30 Aug 2019 09:14:07 +0200 (CEST)
Message-ID: <alpine.DEB.2.21.1908300905100.28828@lancre> (raw)
In-Reply-To: <20190830065905.GA2354@paquier.xyz>
References: <f2554627-04e7-383a-ef01-ab99bb6a291c@2ndquadrant.com>
	<12750.1566743399@sss.pgh.pa.us>
	<CAOBaU_a5kYkR5gV7nCwjY_ZxahzM95=XACSLwg3gd7L59K3JAA@mail.gmail.com>
	<20190826044317.GC7005@paquier.xyz>
	<CALtqXTfTqTsrG4s4rHbHFE9bMwpgX7QWsDuD-hG1yX3BcJD_8Q@mail.gmail.com>
	<2a70fc23-3545-d22d-2071-a42ee18757c9@2ndquadrant.com>
	<alpine.DEB.2.21.1908300842470.28828@lancre>
	<20190830065905.GA2354@paquier.xyz>


Bonjour Michaël,

> I don't see why not.  Perhaps this could be done for pgbench and
> oid2name as well?

This is for pgbench.

I did not found a TAP test in pg_upgrade, I do not think that it is worth 
creating one for that purpose. The "test.sh" script does not seem 
appropriate for this kind of coverage error test.

The TAP test for oid2name only includes basic checks, options and 
arguments are not even tested, and there is no infra for actual testing, 
eg starting a server… Improving that would be a much more significant 
effort that the one line I added to pgbench existing TAP test.

-- 
Fabien.

view thread (15+ messages)  latest in thread

Message-ID: <alpine.DEB.2.21.1908300905100.28828@lancre>
Permalink:  ../alpine.DEB.2.21.1908300905100.28828@lancre/
Also on:    postgresql.org/message-id/alpine.DEB.2.21.1908300905100.28828@lancre

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, ibrar.ahmad@gmail.com, rjuju123@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: pg_upgrade: Error out on too many command-line arguments
  In-Reply-To: <alpine.DEB.2.21.1908300905100.28828@lancre>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox